chore: refresh insta snapshots to latest format#5943
Merged
Conversation
Regenerates inline snapshots with the current cargo-insta version (1.47.2). Drops the `r"` raw-string prefix on `@r"…"` blocks that don't actually need it, normalises indentation on the `r#"…"#` blocks that did, and refreshes a few stale `__results__*.snap` `expression:` fields where the source `.prql` had been edited without an accompanying `cargo insta accept`. Produced by running `INSTA_FORCE_UPDATE=1 cargo insta test --accept --dnd -p prqlc-parser -p prqlc -p prqlc-python --features=default,test-dbs --test-runner=nextest` on `main`. Intended to make #5741 a more manageable diff — once this lands, the inline-snapshot churn there should disappear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshes all
instasnapshots onmainto the format that the currently-pinnedcargo-insta(1.47.2) wants to emit, so that #5741 — which had a lot of incidental snapshot-formatting noise mixed in with its realdate.floorchanges — can rebase to a cleaner diff.Three kinds of churn:
@r"…"→@"…"on inline snapshots whose contents don't need raw-string semanticsr#"…"#blocks re-indented to the formatcargo-instanow writesexpression:fields refreshed on a handful oftests/integration/snapshots/integration__queries__results__*.snapfiles where the source.prqlhad been edited without an accompanyingcargo insta accept(e.g.aggregation.prqlno longer carries# mssql:skip); also strips an outdatedsnapshot_kind: textline ondate_to_text.snapNo behavioural changes — every snapshot's actual content is unchanged. Produced by running
INSTA_FORCE_UPDATE=1 cargo insta test --accept --dnd -p prqlc-parser -p prqlc -p prqlc-python --features=default,test-dbs --test-runner=nextestagainstmain, then verifying withcargo insta test --check.Requested by @max-sixty in #5741 (comment).
Test plan
cargo insta test --check -p prqlc-parser -p prqlc -p prqlc-python— 645 passed, 6 skippedtestsworkflow)