Skip to content

internal: correct two stale comments in nextest config and parser tests #6187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-sixty merged 3 commits into from
Aug 13, 2026
+8 −5
Merged

internal: correct two stale comments in nextest config and parser tests #6187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7e89d7
internal: correct two stale comments in nextest config and parser tests
prql-bot Aug 12, 2026
f59ffac
internal: say 'process' rather than 'compile' in query test comment
prql-bot Aug 12, 2026
a74b57b
internal: order nextest query overrides specific-first
prql-bot Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .config/nextest.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@ fail-fast = false
failure-output = "final"
slow-timeout = { period = "500ms" }

[[profile.default.overrides]]
# compileall does many passes over the same query, so it takes a bit longer
filter = 'package(prqlc) & test(queries::)'
slow-timeout = { period = "2s" }
# Overrides are resolved first-match-wins per setting, so the more specific
# filters need to come before the broad `queries::` one below.

[[profile.default.overrides]]
# compileall does many passes over the same query, so it takes a bit longer
Expand All @@ -18,6 +16,11 @@ filter = 'package(prqlc) & test(queries::results::)'
slow-timeout = { period = "10s" }
test-group = 'test-dbs'

[[profile.default.overrides]]
# the query tests each process a whole `.prql` file, so they take a bit longer
filter = 'package(prqlc) & test(queries::)'
slow-timeout = { period = "2s" }

[test-groups.test-dbs]
# test-dbs runs database setup when the connection is established, and because
# nextest runs test in separate processes, this happens on every test. To
Expand Down
2 changes: 1 addition & 1 deletion prqlc/prqlc-parser/src/parser/stmt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ mod tests {

#[test]
fn doc_comment_inline_module() {
// Check the newline doesn't get eated by the `{}` of the module
// Check the newline doesn't get eaten by the `{}` of the module
// TODO: could give a better error when we forget the module name
assert_yaml_snapshot!(parse_module_contents(r#"
module bar {
Expand Down
Loading