Skip to content

Require taxcalc 6.5.3 or higher#511

Merged
donboyd5 merged 2 commits intomasterfrom
taxcalc-653
Apr 27, 2026
Merged

Require taxcalc 6.5.3 or higher#511
donboyd5 merged 2 commits intomasterfrom
taxcalc-653

Conversation

@martinholmer
Copy link
Copy Markdown
Collaborator

No changes in generated TMD data; just one test change wrt OBBBA senior deduction.
Will be merged after taxcalc 6.5.3 package is available for download.

@martinholmer martinholmer requested a review from donboyd5 April 25, 2026 16:01
@donboyd5
Copy link
Copy Markdown
Collaborator

@martinholmer, verified locally and the change looks good to me -- ready to merge once taxcalc 6.5.3 package is available for download.

I did the following:

  • Checked out PR 511's taxcalc-653 branch.
  • Installed Tax-Calculator from PR #3015's 6-5-3 branch (pip install git+https://github.com/martinholmer/Tax-Calculator.git@6-5-3) so I had taxcalc 6.5.3 in my venv.
  • Ran pytest tests/test_imputed_variables.py -m obbba_deduction -v against the existing tmd/storage/output/tmd.csv.gz (generated previously, unchanged by this PR).

Result
test_obbba_deduction_tax_benefits passes with the updated 2022 expected values (exp_totben_2022=58.89, exp_affpct_2022=28.24, exp_affben_2022=1065). The new numbers are consistent with the per-person phase-out of the OBBBA senior deduction introduced in Tax-Calculator PR #3014.

Merge compatibility
A three-way merge test of this branch against current master (which now includes the recently merged area-weights documentation PR #512) is clean — PR 511's edits to the numbered list in README.md and PR 512's appended "Sub-national area weights" section don't overlap.

One minor note
The PR title and description focus on the taxcalc 6.5.3 requirement, but the diff also includes a small unrelated workflow change: adding clean format lint as prerequisites to the make data target and removing the now-redundant "run make clean first" step from the README. That seems sensible to me (since make data now runs clean itself), just flagging it for informational purposes.

Copy link
Copy Markdown
Collaborator

@donboyd5 donboyd5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please see comments in main conversation.

@martinholmer
Copy link
Copy Markdown
Collaborator Author

@donboyd5, Thanks for checking PR #511 on your computer.

@donboyd5
Copy link
Copy Markdown
Collaborator

@donboyd5, Thanks for checking PR #511 on your computer.

Gladly!

@donboyd5 donboyd5 merged commit 53789b4 into master Apr 27, 2026
1 check passed
@donboyd5
Copy link
Copy Markdown
Collaborator

taxcalc 6.5.3 was released in PR 3015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants