You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No changes in generated TMD data; just one test change wrt OBBBA senior deduction.
Will be merged after taxcalc 6.5.3 package is available for download.
@martinholmer, verified locally and the change looks good to me -- ready to merge once taxcalc 6.5.3 package is available for download.
I did the following:
Checked out PR 511's taxcalc-653 branch.
Installed Tax-Calculator from PR #3015's 6-5-3 branch (pip install git+https://github.com/martinholmer/Tax-Calculator.git@6-5-3) so I had taxcalc 6.5.3 in my venv.
Ran pytest tests/test_imputed_variables.py -m obbba_deduction -v against the existing tmd/storage/output/tmd.csv.gz (generated previously, unchanged by this PR).
Result test_obbba_deduction_tax_benefitspasses with the updated 2022 expected values (exp_totben_2022=58.89, exp_affpct_2022=28.24, exp_affben_2022=1065). The new numbers are consistent with the per-person phase-out of the OBBBA senior deduction introduced in Tax-Calculator PR #3014.
Merge compatibility
A three-way merge test of this branch against current master (which now includes the recently merged area-weights documentation PR #512) is clean — PR 511's edits to the numbered list in README.md and PR 512's appended "Sub-national area weights" section don't overlap.
One minor note
The PR title and description focus on the taxcalc 6.5.3 requirement, but the diff also includes a small unrelated workflow change: adding clean format lint as prerequisites to the make data target and removing the now-redundant "run make clean first" step from the README. That seems sensible to me (since make data now runs clean itself), just flagging it for informational purposes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No changes in generated TMD data; just one test change wrt OBBBA senior deduction.
Will be merged after taxcalc 6.5.3 package is available for download.