Remove obsolete test_tax_revenue.py and its expected-data files#516
Merged
Remove obsolete test_tax_revenue.py and its expected-data files#516
Conversation
The skipped tests/test_tax_revenue.py compared TMD against CBO fiscal-year cash-receipts (Monthly Treasury Statement). That series is structurally not comparable to TaxCalc iitax — it includes Form 1041, Form 1042 / NRA withholding, refund-netting, late assessments, and FY-vs-CY timing — so the test was indefinitely skipped. PR #515 (merged) replaced it with tests/test_revenue_levels_cbo.py, which compares against the calendar-year, 1040-universe liability series in CBO's Revenue file sheet 3. The new test supersedes the old one entirely. Removes: - tests/test_tax_revenue.py - tests/expected_itax_rev_2022_data.yaml (used only by the deleted test) - tests/expected_ptax_rev_2022_data.yaml (used only by the deleted test) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
donboyd5
added a commit
to donboyd5/tax-microdata-benchmarking
that referenced
this pull request
Apr 29, 2026
…ch ready Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skipped tests/test_tax_revenue.py compared TMD against CBO fiscal-year cash-receipts (Monthly Treasury Statement). That series is structurally not comparable to TaxCalc iitax — it includes Form 1041, Form 1042 / NRA withholding, refund-netting, late assessments, and FY-vs-CY timing — so the test was indefinitely skipped. PR #515 (merged) replaced it with
tests/test_revenue_levels_cbo.py, which compares against the calendar-year, 1040-universe liability series in CBO's Revenue file sheet 3. The new test supersedes the old one entirely.
Removes: