Update devcontainer and workflow dependencies - #36
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates devcontainer feature channels and workflow dependencies to newer major versions, and aligns tests/fixtures with the updated generated devcontainer configuration expectations.
Changes:
- Bump
docker-in-dockerfeature from:3→:4across templates, examples, and related tests. - Bump
nodefeature from:1→:2for the TypeScript template and related tests. - Update GitHub Actions workflow to use
actions/checkout@v7.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/templates.ts |
Updates built-in template feature references to docker-in-docker:4 and node:2. |
tests/templates.test.ts |
Updates template expectations (feature refs and pinned reference string) to match new feature channels. |
tests/examples.test.ts |
Updates generated-config assertions for examples to expect docker-in-docker:4 and node:2. |
tests/core.test.ts |
Updates resolve-workspace config expectation to docker-in-docker:4. |
examples/smoke-workspace/.devcontainer/devcontainer.json |
Updates example devcontainer to docker-in-docker:4. |
examples/complex-workspace/.devcontainer/devcontainer.json |
Updates example devcontainer to docker-in-docker:4 and node:2. |
.devcontainer/devcontainer.json |
Updates repository devcontainer to docker-in-docker:4. |
.github/workflows/pr-tests.yml |
Updates checkout action to actions/checkout@v7. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:3to:4and Node from:1to:2across examples and built-in templates.actions/checkoutfrom@v4to@v7.Other infrastructure references were already on their latest stable channels, and package dependencies required no version changes.
Validation
bun test(154 passed, 4 live tests skipped)bun run test:fastbun run typecheckbun run buildLive devcontainer tests were attempted with Docker and Dev Containers CLI 0.88.0 but were blocked by root-owned bind-mount permissions in this environment.