support tf 5.0#5035
Open
zhang-prog wants to merge 4 commits into
Open
Conversation
|
Thanks for your contribution! |
Bobholamovic
reviewed
Mar 5, 2026
Comment on lines
+284
to
+285
| vllm_version = get_dep_version("vllm") | ||
| if vllm_version is not None and Version(vllm_version) >= Version( |
Member
There was a problem hiding this comment.
vllm_version是None应该是一种异常情况，最好报错
Bobholamovic
reviewed
Mar 9, 2026
| if is_cuda_available(): | ||
| if "vllm" in backend: | ||
| vllm_version = get_dep_version("vllm") | ||
| assert ( |
Member
There was a problem hiding this comment.
这里其实可以不用"Could not find vLLM. Please install it by running: 'paddlex --install genai-vllm-server'"，因为这个分支理论上是走不到的（assert never），而且前面已经校验过genai-vllm-server已安装了，这样反而可能给用户误导
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.