Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 115 additions & 0 deletions src/SharedKernel/Helpers/PhoneUtil.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
using System.Text;

namespace SharedKernel.Helpers;

public static class PhoneUtil
{
public static bool TryFormatArmenianMsisdn(string? input, out string? formatted)
{
formatted = null;
if (string.IsNullOrWhiteSpace(input))
{
return false;
}

var s = input.Trim();

// Special-case exact "(374)" prefix
if (s.StartsWith("(374)", StringComparison.Ordinal))
{
var rest = DigitsOnly(s.AsSpan(5));
if (rest.Length == 8)
{
formatted = "+374" + rest;
return true;
}

formatted = input;
return false;
}

// General tolerant parse: allow spaces, dashes, dots, parentheses; '+' only at start
var sb = new StringBuilder(s.Length);
for (var i = 0; i < s.Length; i++)
{
var c = s[i];
if (c is >= '0' and <= '9')
{
sb.Append(c);
continue;
}

if (i == 0 && c == '+')
{
continue;
}

if (c == ' ' || c == '-' || c == '.' || c == '(' || c == ')' || char.IsWhiteSpace(c))
{
continue;
}

formatted = input;
return false;
}

var digits = sb.ToString();
var span = digits.AsSpan();
ReadOnlySpan<char> last8;

var plusAtStart = s[0] == '+';
if (plusAtStart)
{
if (span.Length == 11 && span.StartsWith("374".AsSpan()))
{
last8 = span[3..];
}
else
{
formatted = input;
return false;
}
}
else
{
switch (span.Length)
{
case 11 when span.StartsWith("374".AsSpan()):
last8 = span[3..];
break;
case 9 when span[0] == '0':
last8 = span[1..];
break;
case 8:
last8 = span;
break;
default:
formatted = input;
return false;
}
}

if (last8.Length != 8)
{
formatted = input;
return false;
}

formatted = $"+374{last8.ToString()}";
return true;
}

private static string DigitsOnly(ReadOnlySpan<char> span)
{
var sb = new StringBuilder(span.Length);
foreach (var c in span)
{
if (c is >= '0' and <= '9')
{
sb.Append(c);
}
}

return sb.ToString();
}
}
4 changes: 2 additions & 2 deletions src/SharedKernel/SharedKernel.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
<PackageReadmeFile>Readme.md</PackageReadmeFile>
<Authors>Pandatech</Authors>
<Copyright>MIT</Copyright>
<Version>1.6.4</Version>
<Version>1.6.5</Version>
<PackageId>Pandatech.SharedKernel</PackageId>
<Title>Pandatech Shared Kernel Library</Title>
<PackageTags>Pandatech, shared kernel, library, OpenAPI, Swagger, utilities, scalar</PackageTags>
<Description>Pandatech.SharedKernel provides centralized configurations, utilities, and extensions for ASP.NET Core projects. For more information refere to readme.md document.</Description>
<RepositoryUrl>https://github.com/PandaTechAM/be-lib-sharedkernel</RepositoryUrl>
<PackageReleaseNotes>Nuget updates</PackageReleaseNotes>
<PackageReleaseNotes>Phone util added</PackageReleaseNotes>
</PropertyGroup>

<ItemGroup>
Expand Down
61 changes: 61 additions & 0 deletions test/SharedKernel.Tests/PhoneUtilTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
using SharedKernel.Helpers;

namespace SharedKernel.Tests;

public class PhoneUtilTests
{
[Theory]
[InlineData("+37493910593", "+37493910593")]
[InlineData("37493910593", "+37493910593")]
[InlineData("093910593", "+37493910593")]
[InlineData("93910593", "+37493910593")]
[InlineData("(374)93910593", "+37493910593")]
// tolerant separators
[InlineData("+374 93 910 593", "+37493910593")]
[InlineData("374-93-910-593", "+37493910593")]
[InlineData("(374) 93 910 593", "+37493910593")]
public void Formats_Armenian_Numbers_When_Valid(string input, string expected)
{
var ok = PhoneUtil.TryFormatArmenianMsisdn(input, out var formatted);
Assert.True(ok);
Assert.Equal(expected, formatted);
}

[Theory]
[InlineData("+12025550199")] // foreign
[InlineData("441234567890")] // foreign
[InlineData("+++37493910593")] // invalid
[InlineData("37493A10593")] // invalid char
[InlineData("(374)1234567")] // only 7 digits after prefix
[InlineData("123456789")] // 9 digits but not starting with 0
public void Returns_Original_When_Not_Armenian(string input)
{
var ok = PhoneUtil.TryFormatArmenianMsisdn(input, out var formatted);
Assert.False(ok);
Assert.Equal(input, formatted);
}

[Fact]
public void Empty_String_Returns_False_And_Null()
{
var ok = PhoneUtil.TryFormatArmenianMsisdn("", out var formatted);
Assert.False(ok);
Assert.Null(formatted);
}

[Fact]
public void Whitespace_String_Returns_False_And_Null()
{
var ok = PhoneUtil.TryFormatArmenianMsisdn(" ", out var formatted);
Assert.False(ok);
Assert.Null(formatted);
}

[Fact]
public void Null_Returns_False_And_Null()
{
var ok = PhoneUtil.TryFormatArmenianMsisdn(null, out var formatted);
Assert.False(ok);
Assert.Null(formatted);
}
}