Skip to content

Update Docusaurus to v3#256

Merged
olijeffers0n merged 14 commits into
mainfrom
update_docusaurus_v3
Nov 26, 2023
Merged

Update Docusaurus to v3#256
olijeffers0n merged 14 commits into
mainfrom
update_docusaurus_v3

Conversation

@olijeffers0n
Copy link
Copy Markdown
Member

@olijeffers0n olijeffers0n commented Oct 10, 2023 •
edited
Loading

Docusaurus v3 has been released bringing some slight Markdown changes. Namely, curly braces may need escaping within markdown and <! -- --> comments are not supported

@olijeffers0n olijeffers0n changed the title Update to Docusaurus to v3 Update Docusaurus to v3 Oct 10, 2023
@olijeffers0n
Copy link
Copy Markdown
Member Author

olijeffers0n commented Oct 19, 2023

I have done some looking through the deployment and I believe everything is alright. If anyone can have a look through that would be appreciated 😄

@olijeffers0n olijeffers0n marked this pull request as draft October 26, 2023 18:18
@e-im
Copy link
Copy Markdown
Contributor

e-im commented Oct 31, 2023

3.0 is out now. Looking at the changes between this pr and the actual release it should just be a matter of updating the packages.

The primary change is an update from MDX v2 to the newly released MDX 3

This sounds pretty major (i.e. v1 -> v2), but its actually just a few very small changes, hence why it was added at the very end. We don't inferface with MDX directly hence no changes are needed. It's only new features

@olijeffers0n
Copy link
Copy Markdown
Member Author

olijeffers0n commented Oct 31, 2023

Yep! Got the notification too. I marked it as draft when the RC came out. I’ll be looking to update in the coming days around Uni work. Someone poke me if i forget 😝

@e-im
Copy link
Copy Markdown
Contributor

e-im commented Oct 31, 2023

I had missed this initially but the patch for @docusaurus/core can also now be removed because loading typescript config files is now natively supported facebook/docusaurus#9317

@olijeffers0n
Merge branch 'main' into update_docusaurus_v3
490d9ca 
# Conflicts:
#	docs/velocity/dev/getting-started/creating-your-first-plugin.mdx
@olijeffers0n
Merge remote-tracking branch 'origin/update_docusaurus_v3' into updat…
ff48038 
…e_docusaurus_v3
@olijeffers0n olijeffers0n marked this pull request as ready for review November 3, 2023 16:28
@olijeffers0n
Copy link
Copy Markdown
Member Author

olijeffers0n commented Nov 3, 2023

Okey, all patches are updated. Ready for reviewal

powercasgamer
powercasgamer suggested changes Nov 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@powercasgamer powercasgamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Internationalization page should probably also be added to Velocity

@olijeffers0n olijeffers0n merged commit 7383a5c into main Nov 26, 2023
@olijeffers0n olijeffers0n deleted the update_docusaurus_v3 branch November 26, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Machine-Maker Machine-Maker Machine-Maker approved these changes

+1 more reviewer

@powercasgamer powercasgamer powercasgamer requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@olijeffers0n @e-im @Machine-Maker @powercasgamer