Skip to content

Bump Microsoft.Data.SqlClient from 2.1.2 to 4.0.0#2711

Closed
dependabot[bot] wants to merge 2 commits into
masterfrom
dependabot/nuget/Microsoft.Data.SqlClient-4.0.0
Closed

Bump Microsoft.Data.SqlClient from 2.1.2 to 4.0.0#2711
dependabot[bot] wants to merge 2 commits into
masterfrom
dependabot/nuget/Microsoft.Data.SqlClient-4.0.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Nov 22, 2021 •
edited by tmasternak
Loading

Do not merge see comment for more details

Bumps Microsoft.Data.SqlClient from 2.1.2 to 4.0.0.

Release notes

Sourced from Microsoft.Data.SqlClient's releases.

Stable Release v4.0.0

Added

  • Added missing SqlClientLogger class to .NET Core refs and missing SqlClientLogger.LogWarning method in .NET Framework refs #1392

Changed

  • Avoid throwing unnecessary exception when an invalid SqlNotificationInfo value is received from SQL Server #1378
  • Updated Microsoft.Data.SqlClient.SNI (.NET Framework dependency) and Microsoft.Data.SqlClient.SNI.runtime (.NET Core/Standard dependency) version to v4.0.0 #1391

For summary of all changes over v3.0, refer to 4.0.0.md

Preview Release v4.0.0-preview3.21293.2

Breaking changes over preview release v4.0.0-preview2

  • Dropped support for .NET Core 2.1 #1272
  • [.NET Framework] Exception will not be thrown if a User ID is provided in the connection string when using Active Directory Integrated authentication #1359

Added

  • Add GetFieldValueAsync<T> and GetFieldValue<T> support for XmlReader, TextReader, Stream #1019

Fixed

  • Fixed FormatException when opening a connection with event tracing enabled #1291
  • Fixed improper initialization of ActiveDirectoryAuthenticationProvider #1328
  • Fixed MissingMethodException when accessing SqlAuthenticationParameters.ConnectionTimeout #1336
  • Fixed data corruption issues by reverting changes to async cancellations #1352
  • Fixed performance degradation by reverting changes to MARS state machine #1357
  • Fixed bug where environment variables are ignored when using Active Directory Default authentication #1360

Changed

  • Removed attributes for classes used in Microsoft.VSDesigner due to lack of support for Microsoft.Data.SqlClient #1296
  • Disable encryption when connecting to SQL LocalDB #1312
  • Various code health and performance improvements. See milestone for more info.

For detailed release notes, refer 4.0.0-preview3.md

Preview Release v4.0.0-preview2.21264.2

Breaking changes over preview release v4.0.0-preview1

  • Removed Configurable Retry Logic safety switch. #1254

Added

  • Added support for SqlFileStream on Windows using .NET Standard 2.0 and above. #1240
  • Added support for localdb shared instance using managed SNI. #1237

Fixed

... (truncated)

Changelog

Sourced from Microsoft.Data.SqlClient's changelog.

[Stable Release 4.0.0] - 2021-11-18

Added

  • Added missing SqlClientLogger class to .NET Core refs and missing 'SqlClientLogger.LogWarning' method in .NET Framework refs #1392

Changed

  • Avoid throwing unnecessary exception when an invalid SqlNotificationInfo value is received from SQL Server #1378
  • Updated Microsoft.Data.SqlClient.SNI (.NET Framework dependency) and Microsoft.Data.SqlClient.SNI.runtime (.NET Core/Standard dependency) version to v4.0.0 #1391

[Preview Release 4.0.0-preview3.21293.2] - 2021-10-20

This update brings the below changes over the previous release:

Breaking changes over preview release v4.0.0-preview2

  • Dropped support for .NET Core 2.1 #1272
  • [.NET Framework] Exception will not be thrown if a User ID is provided in the connection string when using Active Directory Integrated authentication #1359

Added

  • Add GetFieldValueAsync<T> and GetFieldValue<T> support for XmlReader, TextReader, Stream #1019

Fixed

  • Fixed FormatException when opening a connection with event tracing enabled #1291
  • Fixed improper initialization of ActiveDirectoryAuthenticationProvider #1328
  • Fixed MissingMethodException when accessing SqlAuthenticationParameters.ConnectionTimeout #1336
  • Fixed data corruption issues by reverting changes to async cancellations #1352
  • Fixed performance degradation by reverting changes to MARS state machine #1357
  • Fixed bug where environment variables are ignored when using Active Directory Default authentication #1360

Changed

  • Removed attributes for classes used in Microsoft.VSDesigner due to lack of support for Microsoft.Data.SqlClient #1296
  • Disable encryption when connecting to SQL LocalDB #1312
  • Various code health and performance improvements. See milestone for more info.

[Preview Release 4.0.0-preview2.21264.2] - 2021-09-21

This update brings the below changes over the previous release:

Breaking changes over preview release v4.0.0-preview1

  • Removed Configurable Retry Logic safety switch. #1254

Added

  • Added support for SqlFileStream on Windows using .NET Standard 2.0 and above. #1240

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot Bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Nov 22, 2021
@dependabot dependabot Bot mentioned this pull request Nov 22, 2021
Closed
@mikeminutillo
Copy link
Copy Markdown
Member

mikeminutillo commented Nov 24, 2021

@dependabot rebase

@dependabot dependabot Bot force-pushed the dependabot/nuget/Microsoft.Data.SqlClient-4.0.0 branch from 2fc9069 to 94512a8 Compare November 24, 2021 03:08
@dependabot
Bump Microsoft.Data.SqlClient from 2.1.2 to 4.0.0
4921173 
Bumps [Microsoft.Data.SqlClient](https://github.com/dotnet/sqlclient) from 2.1.2 to 4.0.0.
- [Release notes](https://github.com/dotnet/sqlclient/releases)
- [Changelog](https://github.com/dotnet/SqlClient/blob/main/CHANGELOG.md)
- [Commits](dotnet/SqlClient@v2.1.2...v4.0.0)

---
updated-dependencies:
- dependency-name: Microsoft.Data.SqlClient
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/nuget/Microsoft.Data.SqlClient-4.0.0 branch from 94512a8 to 4921173 Compare December 3, 2021 13:34
@tmasternak
Copy link
Copy Markdown
Member

tmasternak commented Dec 7, 2021 •
edited
Loading

Microsoft.Data.SqlClinet version 3.0.1 has a breaking change that turns connection encryption on by default via. Encryption=True.

What this means to ServiceControl users is that after the upgrade the instance will fail to start for any user that wasn't using the encryption previously. This is likely to be the majority of our users.

TL;DR; This should probably get out only in the next major.

@mikeminutillo
Copy link
Copy Markdown
Member

mikeminutillo commented Dec 8, 2021

@tmasternak Can we detect that Encryption is not being used with a custom check and warn users that they should enable it?

@tmasternak
Copy link
Copy Markdown
Member

tmasternak commented Dec 9, 2021

@tmasternak Can we detect that Encryption is not being used with a custom check and warn users that they should enable it?

@mikeminutillo This should be possible. That being said I'm not sure what is the SC behavior when this (not being able to connect to the SQL instance) happens. Secondly, this is a breaking change for SqlT and SqlP as well which should probably be handled all at once (especially the communication part of things).

@mikeminutillo
Copy link
Copy Markdown
Member

mikeminutillo commented Dec 9, 2021

@tmasternak I meant to do the custom check now, before applying this dependency update to give customers on the old version of the library the chance to enable encryption before we do anything.

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github Jan 18, 2022

A newer version of Microsoft.Data.SqlClient exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@kentdr
Copy link
Copy Markdown
Contributor

kentdr commented Mar 2, 2022

Closing this issue so a new one can be re-created by dependabot.

@kentdr kentdr closed this Mar 2, 2022
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github Mar 2, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot Bot deleted the dependabot/nuget/Microsoft.Data.SqlClient-4.0.0 branch March 2, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikeminutillo mikeminutillo Awaiting requested review from mikeminutillo

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .net code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikeminutillo @tmasternak @kentdr @bording