Skip to content

Handler saga registration#8214

Merged
danielmarbach merged 10 commits into
core-10.2from
handler-saga-registration
May 5, 2026
Merged

Handler saga registration#8214
danielmarbach merged 10 commits into
core-10.2from
handler-saga-registration

Conversation

@danielmarbach
Copy link
Copy Markdown
Contributor

@danielmarbach danielmarbach commented Apr 27, 2026

No description provided.

@danielmarbach danielmarbach force-pushed the handler-saga-registration branch from 048f514 to 8e14126 Compare April 28, 2026 06:41
@danielmarbach danielmarbach changed the base branch from master to core-10.2 April 30, 2026 05:58
andreasohlund
andreasohlund reviewed Apr 30, 2026
View reviewed changes
Comment thread nservicebus/handlers-and-sagas-registration.md Outdated
Comment thread nservicebus/handlers-and-sagas-registration_registration-content_core_[10,).partial.md Outdated
Comment thread nservicebus/handlers-and-sagas-registration_registration-content_core_[10,).partial.md
Comment on lines +66 to +74
### Enable a feature

Use `EnableFeature<TFeature>()` to enable a feature:

snippet: EnableFeatureManually

### Register an installer

Use `AddInstaller<TInstaller>()` to register an installer:
Copy link
Copy Markdown
Member

@andreasohlund andreasohlund Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we also documents this in the specific feature and installer docs

Copy link
Copy Markdown
Contributor Author

@danielmarbach danielmarbach Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes there is a slight redundancy now. We could also remove those sections here

@danielmarbach danielmarbach force-pushed the handler-saga-registration branch from 3aa8037 to adafc2c Compare May 1, 2026 15:00
@danielmarbach danielmarbach marked this pull request as ready for review May 1, 2026 15:00
@danielmarbach
Copy link
Copy Markdown
Contributor Author

danielmarbach commented May 1, 2026

@DavidBoike any thoughts?

@DavidBoike DavidBoike force-pushed the handler-saga-registration branch from adafc2c to a160c0c Compare May 1, 2026 18:27
DavidBoike
DavidBoike requested changes May 4, 2026
View reviewed changes
Comment thread nservicebus/handlers-and-sagas-registration_registration-content_core_[10,).partial.md
Comment thread nservicebus/handlers-and-sagas-registration_registration-content_core_[10,).partial.md
Comment thread nservicebus/handlers-and-sagas-registration_registration-content_core_[10,).partial.md Outdated
Comment thread nservicebus/handlers-and-sagas-registration_registration-content_core_[10,).partial.md Outdated
@danielmarbach danielmarbach force-pushed the handler-saga-registration branch 2 times, most recently from 8f23ed1 to be0f90d Compare May 5, 2026 07:45
andreasohlund
andreasohlund reviewed May 5, 2026
View reviewed changes
Comment thread tools/build-samples-and-snippets.ps1
@@ -1,8 +1,3 @@
[CmdletBinding()]
Copy link
Copy Markdown
Member

@andreasohlund andreasohlund May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes here can be reverted, main branch already have a better approach

Copy link
Copy Markdown
Contributor Author

@danielmarbach danielmarbach May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@danielmarbach danielmarbach force-pushed the handler-saga-registration branch from be0f90d to 545b6a5 Compare May 5, 2026 08:19
@danielmarbach
Copy link
Copy Markdown
Contributor Author

danielmarbach commented May 5, 2026

Merging. We can do further tweaks on the Core branch if needed

@danielmarbach danielmarbach merged commit 2e93809 into core-10.2 May 5, 2026
3 of 4 checks passed
@danielmarbach danielmarbach deleted the handler-saga-registration branch May 5, 2026 08:22
DavidBoike pushed a commit that referenced this pull request May 5, 2026
@danielmarbach @andreasohlund @DavidBoike
Handler saga registration (#8214)
1f90e68 
* Registration page first version while keeping some redundancy

* Fix missing index problem

* Better page split and wording tweaks

* Refactor handler registration example in documentation

Updated the registration code example to reflect new API usage.

* Small tweaks

* Fix version boundary to use integer majors

* Apply suggestions from code review

Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>

* Switch order

* Better documentation around the conventions

* Explain better the conventions

---------

Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>
mattmercurio pushed a commit that referenced this pull request May 18, 2026
@danielmarbach @andreasohlund @mattmercurio
Handler saga registration (#8214)
304c888 
* Registration page first version while keeping some redundancy

* Fix missing index problem

* Better page split and wording tweaks

* Refactor handler registration example in documentation

Updated the registration code example to reflect new API usage.

* Small tweaks

* Fix version boundary to use integer majors

* Apply suggestions from code review

Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>

* Switch order

* Better documentation around the conventions

* Explain better the conventions

---------

Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>
DavidBoike pushed a commit that referenced this pull request May 20, 2026
@danielmarbach @andreasohlund @DavidBoike
Handler saga registration (#8214)
720ec0c 
* Registration page first version while keeping some redundancy

* Fix missing index problem

* Better page split and wording tweaks

* Refactor handler registration example in documentation

Updated the registration code example to reflect new API usage.

* Small tweaks

* Fix version boundary to use integer majors

* Apply suggestions from code review

Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>

* Switch order

* Better documentation around the conventions

* Explain better the conventions

---------

Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>
DavidBoike added a commit that referenced this pull request May 21, 2026
@DavidBoike @andreasohlund
@danielmarbach @mattmercurio
Documentation for NServiceBus 10.2.0 (#8225)
365795d 
* Core8 transitive reference fix

* Core 10.2 alpha 5

* Restore modern logging info

* Swap out a bunch of IEndpointInstance for IMessageSession (or burn IEndpointIntance)

* A bunch of weird Writer tests (disabled TreatWarningsAsErrors locally to run tests)

* Suppress obsoletes for selfhosting snippets still supported in v10

* Suppress obsoletes for snippets that should still exist in v10

* One more suppression

* Fix general installer snippet

* Guide towards the new installer API

* Suppress log obsoletes

* Slight change to installer snippet

* Convention-based handlers (#8224)

* Convention-based handlers

* Apply suggestions from code review

Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net>
Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>

* Make a TLDR snippet

* Whoopsie

---------

Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net>
Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>

* Handler saga registration (#8214)

* Registration page first version while keeping some redundancy

* Fix missing index problem

* Better page split and wording tweaks

* Refactor handler registration example in documentation

Updated the registration code example to reflect new API usage.

* Small tweaks

* Fix version boundary to use integer majors

* Apply suggestions from code review

Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>

* Switch order

* Better documentation around the conventions

* Explain better the conventions

---------

Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>

* Address deprecated Endpoint APIs in samples (#8236)

* 2 projects needed a Core reference

* Change affected samples to Core 10 alphas

* Easy NSB.Extensions.Hosting removals

* Rest of NSB.Extensions.Hosting

* Delete "Passing user identity between endpoints using a custom header" sample that uses mutators

* Remove "Startup and Shutdown Sequence" sample

* Fix deprecated APIs in 4 samples

* Updated more samples

* Bunch more samples

* Fix bad cancellation token usage

* Couple more

* Need to review this Kafka-Functions sample separately

* Kinda big SqlP sample

* Bunch more

* Version-scope the externally managed mode sample and add a warning

* Remaining samples

* Fix links and related

* Another fix

* Core-hosting with AddNServiceBusEndpoint (#8206)

* Add AddNServiceBusEndpoint hosting page

* Core hosting guidance

* Core hosting guidance

* Modern hosting language changes

* Core-hosting and snippets

* 'Recommended' hosting wording

* Update nservicebus/hosting/core-hosting.md

Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net>

* Apply suggestions from code review

Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net>

* Update nservicebus/hosting/core-hosting.md

Co-authored-by: David Boike <david.boike@gmail.com>

* Per-tenant hosting scenario

* Reframe core-hosting opening and rewrite endpoint name / DI identifier section as comparison table

* Clarify IMessageSession resolution and add explicit DI examples

* revert critical-errors.md changes

* Drop upgrade-guide content from core-hosting.md

* Use partials for hosting/index.md generic-host section

* Rename hosting title to Microsoft.Extensions.Hosting instead of 'recommended'

* Tighten multi-endpoint section

* Clarify DI identifier and rework per-tenant example

* Use partials for web-application hosting

* Took out note on NServiceBus.Extensions.Hosting

* Apply suggestions from code review

Co-authored-by: David Boike <david.boike@gmail.com>

* Rename MyService to MyGlobalService

* Note that NServiceBus.Extensions.Hosting is deprecated in 10.2

* Use endpoint identifier terminology instead of "DI indentifier"

* Scope per-tenant identifier with endpoint name to avoid collision

* Show host construction inline for IMessageSession resolution

* Version-gate self-hosting on hosting/index

* Applying PR suggestions with minor edits

* Apply suggestions from code review

Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net>

* Fix Core snippets for extension method alignment

* Apply suggestions from code review

Co-authored-by: David Boike <david.boike@gmail.com>

---------

Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net>
Co-authored-by: David Boike <david.boike@gmail.com>

* Add links to Externally Managed Mode sample

* Update hosting index page (#8243)

* The self-hosting section stops with v9

* Fix header hierarchy and fix resulting links

* No point defining a term we say nothing useful about

* Don't need a whole H2 section for a footnote

* This just doesn't make sense to have anymore (and people using Endpoint.Start() will figure that out)

* WriteDiagnosticsToLog

* Host ID (#8246)

* Host id override

* Improve the guidance because SHA1 was only FIPS compliance on .NET Framework

* Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Make the message consistent in regards to non-crypto hashing

* Less absolute

* Apply suggestions from code review

Co-authored-by: David Boike <david.boike@gmail.com>

---------

Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: David Boike <david.boike@gmail.com>

* Add EndpointLoggingScope documentation for NServiceBus 10.2 (#8261)

- Add 'Enriching logs outside the message pipeline' section to logging docs
- Add MyBackgroundService snippet demonstrating BeginEndpointScope usage
- Update NServiceBus to 10.2.0-alpha.12 for EndpointLoggingScope type
- Refactor Recoverability/Pipeline.cs to use context.MessageId/context.Body
  instead of obsolete context.FailedMessage

Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>

* Update stable

* Fix links (fingers crossed)

---------

Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>
Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net>
Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
Co-authored-by: Matt Mercurio <mattmercurio@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
andreasohlund added a commit that referenced this pull request May 22, 2026
@danielmarbach @andreasohlund
Handler saga registration (#8214)
1fb2db0 
* Registration page first version while keeping some redundancy

* Fix missing index problem

* Better page split and wording tweaks

* Refactor handler registration example in documentation

Updated the registration code example to reflect new API usage.

* Small tweaks

* Fix version boundary to use integer majors

* Apply suggestions from code review

Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>

* Switch order

* Better documentation around the conventions

* Explain better the conventions

---------

Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreasohlund andreasohlund andreasohlund approved these changes

@DavidBoike DavidBoike DavidBoike requested changes

@mattmercurio mattmercurio Awaiting requested review from mattmercurio

Assignees

@danielmarbach danielmarbach

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielmarbach @andreasohlund @DavidBoike