Skip to content

docs(dip-26): address review feedback#2

Merged
PastaPastaPasta merged 1 commit into
PastaPastaPasta:codex/masternode-reward-sharesfrom
thepastaclaw:fix/dip26-review-followup
Jun 20, 2026
Merged

docs(dip-26): address review feedback#2
PastaPastaPasta merged 1 commit into
PastaPastaPasta:codex/masternode-reward-sharesfrom
thepastaclaw:fix/dip26-review-followup

Conversation

@thepastaclaw

Copy link
Copy Markdown

Summary

  • revert the unrelated README wording change flagged by Udjin while keeping the DIP-26 index update
  • clarify that DIP-26 payout lists apply only to owner payouts and do not change ProUpServTx operator payouts
  • add DIP-3 version-4 cross-references/table rows for ProRegTx and ProUpRegTx so DIP-3 stays consistent with DIP-26

Validation

  • git diff --check
  • npx --yes markdownlint-cli2 dip-0003.md dip-0026.md
  • code-review dashpay/dips pr-184 fix/dip26-review-followup "Pre-PR review: address DIP-26 review feedback with README revert, DIP-3 v4 notes, and owner-vs-operator payout clarification" → ship

Note: README.md is reverted to the existing upstream wording for the reviewed line; linting that file alone still reports the pre-existing MD059 warning for [here].

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fb6e4dfb-d878-4b39-88c7-5480af5f8a1a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PastaPastaPasta
PastaPastaPasta merged commit f8dbe85 into PastaPastaPasta:codex/masternode-reward-shares Jun 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants