Added NO-HASH option for ECDSA, for cases the data is already hashed#64
Open
nirfireblocks wants to merge 1 commit intoPeculiarVentures:masterfrom
Open
Added NO-HASH option for ECDSA, for cases the data is already hashed#64nirfireblocks wants to merge 1 commit intoPeculiarVentures:masterfrom
nirfireblocks wants to merge 1 commit intoPeculiarVentures:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ran into a use case where the data to be signed via ECDSA is already hashed, and should not be hashed again. I added the option to do with the hash algorithm
"NO-HASH".This is in conjuncture with a node-webcrypto-p11 pull request.