Skip to content

Remove unused error ERC20InvalidApprover #47

@adamgall

Description

@adamgall

There is an unused error in ERC20Facet.sol: ERC20InvalidApprover.

The options are to remove it, or use it.

I don't think it's needed because:

  • approve() uses msg.sender as approver, which can never be address(0)
  • permit() signature verification would fail for address(0) anyway

Originally posted by @adamgall in #40 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions