Proposal - Move ERC20 and other errors to interfaces

[cyotee]

Intent

Interfaces primarily exist for external users. It is a contract with users consuming your code. Including types needed by external users.

Problem

Custom error are currently buried in libraries. Meaning they're not easily accessible to external users. This makes it impossible for UI developers to have canonical access to those errors. They would have to reimplement those errors elsewhere, introducing the chance for errors, and making it difficult to adopt Compose as a framework.

Solution

Follow the industry standard of declaring errors in interfaces. You don't have to inherit those interfaces into facets. But at least having them present and using those errors in the libraries will ensure consistency while making them externally consumable.

[akronim26]

I would love to work on this one. Could you assign it to me?

[mudgen]

At this point interfaces may be made and put in an interfaces directory, so they can be accessed by users in the future. Only standard interfaces such as ERC20, ERC721 etc. should be made. Interfaces may not be imported or used by contracts or libraries within Compose. That may change in the future.

@cyotee do you want to do this or should @akronim26 do it?

[ogazboiz]

@mudgen i would love to work on this

[mudgen]

@cyotee you brought this up, who should do it? @akronim26 and @ogazboiz want to do it.

[maxnorm]

let me know who's working on this so i can assign this issue

[cyotee]

@cyotee you brought this up, who should do it? @akronim26 and @ogazboiz want to do it.

@mudgen Let's give it to @ogazboiz to complete. Looks like they're learning, and this is good practice. But put @akronim26 as a reviewer because they have more experience. Stretch those management muscles.

@maxnorm That sounds good to you?

[maxnorm]

@cyotee you brought this up, who should do it? @akronim26 and @ogazboiz want to do it.

@mudgen Let's give it to @ogazboiz to complete. Looks like they're learning, and this is good practice. But put @akronim26 as a reviewer because they have more experience. Stretch those management muscles.

@maxnorm That sounds good to you?

Sounds good to me! @ogazboiz & @akronim26, are you good with that?

You can always help each other & collab on this. If you have any questions, feel free to ping us here.

[ogazboiz]

alright @maxnorm and @akronim26 thank you

[ogazboiz]

I've created a PR to address this issue: #84

The PR moves all custom errors from libraries to interfaces, making them accessible to external users. This includes:

• ERC20 errors moved to IERC20.sol
• ERC721 errors moved to IERC721.sol
• ERC721Enumerable errors moved to IERC721Enumerable.sol
• ERC173 errors moved to IERC173.sol

All libraries and facets now import errors from these interfaces instead of defining them locally. This follows the industry standard and gives UI developers canonical access to error definitions.

The implementation maintains full backward compatibility and all tests pass.

@akronim26 you can review it

cc: @maxnorm @mudgen @cyotee

[mudgen]

@ogazboiz , I see it and I reviewed it.