test: remove gas tests and standardize fuzz test naming#133
Merged
Conversation
Contributor
|
@adamgall Great to improve this stuff. Got some failing gas tests in this one. Also, sent you a message on discord. |
Collaborator
Author
|
will fix these broken actions |
adamgall
force-pushed
the
test-cleanup
branch
from
6c4a61b to
bf2e3a6
Compare
Contributor
Coverage Report
Last updated: Mon, 27 Oct 2025 03:41:01 GMT for commit |
adamgall
changed the title
Remove all explicit gas tests from the codebase as they are an anti-pattern that creates maintenance burden without providing real value. Gas costs vary between compiler versions, optimization settings, and coverage runs, making exact assertions fragile and requiring constant updates. Changes: - Remove 14 gas tests across Owner and OwnerTwoSteps test files - Standardize fuzz test naming from `test_Fuzz_*` to `testFuzz_*` convention - Clean up test files by removing gas measurement code (gasleft, gasUsed, etc.) Gas tests removed from: - test/access/Owner/LibOwner.t.sol (3 tests) - test/access/Owner/OwnerFacet.t.sol (2 tests) - test/access/OwnerTwoSteps/LibOwnerTwoSteps.t.sol (4 tests) - test/access/OwnerTwoSteps/OwnerTwoSteps.t.sol (5 tests) Fuzz test naming fixed in: - test/token/ERC20/ERC20/ERC20Facet.t.sol - test/token/ERC20/ERC20/LibERC20.t.sol
adamgall
force-pushed
the
test-cleanup
branch
from
bf2e3a6 to
688d284
Compare
JackieXu
pushed a commit
to JackieXu/Compose
that referenced
this pull request
Nov 6, 2025
test: remove gas tests and standardize fuzz test naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all explicit gas tests from the codebase as they are an anti-pattern
that creates maintenance burden without providing real value. Gas costs vary
between compiler versions, optimization settings, and coverage runs, making
exact assertions fragile and requiring constant updates.
Changes:
test_Fuzz_*totestFuzz_*conventionGas tests removed from:
Fuzz test naming fixed in: