Implement ERC-165 facet and library for interface detection by ogazboiz · Pull Request #137 · Perfect-Abstractions/Compose

ogazboiz · 2025-10-27T05:46:20Z

Added ERC-165 support to the diamond pattern.
Created:

IERC165 interface in src/interfaces/IERC165.sol
LibERC165 library in src/libraries/LibERC165.sol
ERC165Facet in src/diamond/ERC165Facet.sol

Behavior:

supportsInterface() returns true for the ERC-165 interface ID
Use registerInterface() during initialization to register other interfaces
Mapping-based storage at compose.erc165

Files compile without errors and follow the project’s ERC-8042 storage layout.
Addresses #123.

…ose into feat/erc165-facet

github-actions · 2025-10-27T05:47:06Z

Coverage Report

Metric	Coverage	Details
Lines	40%	423/1059 lines
Functions	54%	101/187 functions
Branches	25%	45/178 branches

Last updated: Mon, 27 Oct 2025 23:36:13 GMT for commit c7c53a0

ogazboiz · 2025-10-27T07:50:12Z

@mudgen please kindly review

mudgen · 2025-10-27T13:27:43Z

@ogazboiz We have two pull requests for this. Should we have two for some reason? Or can you close one of them?

ogazboiz · 2025-10-27T13:30:59Z

@mudgen it was a mistake

ogazboiz · 2025-10-27T13:31:44Z

@mudgen i have close one

mudgen

@ogazboiz Thanks for submitting this.

Please review my comments. The README and CONTRIBUTING documentation has been updated. Please read them, so you can better understand how we are designing Compose.

Please create this new directory: src/interfaceDetection. And create this directory in that: ERC165. Put all your source code in that directory, including your IERC165.sol. No libraries directory.

Thanks for your work on this and I look forward to merging the pull request when the changes are done.

mudgen · 2025-10-27T13:46:33Z

+import {IERC165} from "../interfaces/IERC165.sol";
+import {LibERC165} from "../libraries/LibERC165.sol";


Please remove these imports. Each facet is a standard alone source code file.

mudgen · 2025-10-27T13:46:53Z

+/// @title ERC165Facet — ERC-165 Standard Interface Detection Facet
+/// @notice Facet implementation of ERC-165 for diamond proxy pattern
+/// @dev Allows querying which interfaces are implemented by the diamond
+contract ERC165Facet is IERC165 {


uh-oh, submitting a pull request with a facet that uses inheritance is a finable offense. Well, since I really appreciate you working on this and it is valuable, we'll let you pass this time.

Please remove the inheritance.

mudgen · 2025-10-27T13:47:13Z

+// SPDX-License-Identifier: MIT
+pragma solidity >=0.8.30;
+
+import {IERC165} from "../interfaces/IERC165.sol";


Please remove this. We currently do not use interfaces.

ogazboiz · 2025-10-27T15:24:10Z

thanks for the feedback because i want to be good in this open source contribution

mudgen · 2025-10-27T15:32:34Z

thanks for the feedback because i want to be good in this open source contribution

Excellent. I look forward to your changes.

ogazboiz · 2025-10-27T15:33:51Z

thanks for the feedback because i want to be good in this open source contribution

Excellent. I look forward to your changes.

should i still create a standalone interfaces for the 165 too in the interface folder?

… directory

ogazboiz · 2025-10-27T15:52:24Z

Created directory src/interfaceDetection/ERC165.

Moved the ERC165Facet into that directory. Removed passage and imports. The facet is standalone with the interface defined inline.

Removed the library file and separate interface file.

The facet follows SCOP principles. No inheritance. No imports. Uses ERC-8042 diamond storage.

Files formatted and building. Ready for your review.

@mudgen

ogazboiz · 2025-10-27T16:53:35Z

@mudgen did i get it right

panditdhamdhere · 2025-10-27T17:19:43Z

Hi @ogazboiz your willingness to learn and adapt to our project's architecture is commendable. Once these changes are made, this will be a valuable addition to the Compose library.

Please let us know if you need clarification on any of these requirements!

ogazboiz · 2025-10-27T17:21:48Z

Hi @ogazboiz your willingness to learn and adapt to our project's architecture is commendable. Once these changes are made, this will be a valuable addition to the Compose library.

Please let us know if you need clarification on any of these requirements!

I have made the changes and am now waiting for feedback. I follow you on Twitter and have been following your journey since you applied for jobs.

mudgen

@ogazboiz Did you read the README and the CONTRIBUTING files so you can understand how we are writing these files? Do those make sense to you? Any questions about them?

ERC165Facet.sol is in the right directory now, thanks.

ERC165Facet.sol looks good now, but please remove the registerInterface internal function, since it is unused. The interface defined inline like that is fine.

Please undelete the LibERC165.sol file. It belongs in the same directory as ERC165Facet.sol. But please delete the supportsInterface function from LibERC165.sol because I don't think it is needed in the library file.

Thanks.

ogazboiz · 2025-10-27T23:47:37Z

@ogazboiz Did you read the README and the CONTRIBUTING files so you can understand how we are writing these files? Do those make sense to you? Any questions about them?

ERC165Facet.sol is in the right directory now, thanks.

ERC165Facet.sol looks good now, but please remove the registerInterface internal function, since it is unused. The interface defined inline like that is fine.

Please undelete the LibERC165.sol file. It belongs in the same directory as ERC165Facet.sol. But please delete the supportsInterface function from LibERC165.sol because I don't think it is needed in the library file.

Thanks.

@mudgen Thank you for your patience and the detailed feedback.

Yes, I read both files.

I now understand the project's approach. Facets are standalone with all code in one file. Libraries help developers integrate with those facets.

Here’s what I did:

Removed registerInterface from ERC165Facet.sol.
Created LibERC165.sol in src/interfaceDetection/ERC165/.
LibERC165 includes:
- Same storage struct and getStorage function
- registerInterface only
- No supportsInterface
Both files share the same storage slot keccak256("compose.erc165").

Changes are committed. Ready for review.

mudgen · 2025-10-28T01:40:21Z

@ogazboiz Very good. Good job. Merged.

…-facet Implement ERC-165 facet and library for interface detection

ogazboiz added 3 commits October 27, 2025 06:35

Implement ERC-165 facet and library for interface detection

5547af7

Implement ERC-165 facet and library for interface detection

9894476

Merge branch 'feat/erc165-facet' of github.com-personal:ogazboiz/Comp…

b0373cb

…ose into feat/erc165-facet

ogazboiz closed this Oct 27, 2025

ogazboiz reopened this Oct 27, 2025

mudgen self-requested a review October 27, 2025 13:28

mudgen requested changes Oct 27, 2025

View reviewed changes

Refactor ERC165Facet to standalone architecture in interfaceDetection…

0a11516

… directory

mudgen requested changes Oct 27, 2025

View reviewed changes

Comment thread src/interfaceDetection/ERC165/ERC165Facet.sol Outdated

Remove registerInterface from ERC165Facet and add LibERC165 library

c7c53a0

mudgen merged commit c77fabb into Perfect-Abstractions:main Oct 28, 2025
3 checks passed

JackieXu pushed a commit to JackieXu/Compose that referenced this pull request Nov 6, 2025

Merge pull request Perfect-Abstractions#137 from ogazboiz/feat/erc165…

f9b5255

…-facet Implement ERC-165 facet and library for interface detection

		import {IERC165} from "../interfaces/IERC165.sol";
		import {LibERC165} from "../libraries/LibERC165.sol";

Conversation

ogazboiz commented Oct 27, 2025

Uh oh!

github-actions Bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

ogazboiz commented Oct 27, 2025

Uh oh!

mudgen commented Oct 27, 2025

Uh oh!

ogazboiz commented Oct 27, 2025

Uh oh!

ogazboiz commented Oct 27, 2025

Uh oh!

mudgen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mudgen Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

mudgen Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

mudgen Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

ogazboiz commented Oct 27, 2025

Uh oh!

mudgen commented Oct 27, 2025

Uh oh!

ogazboiz commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ogazboiz commented Oct 27, 2025

Uh oh!

ogazboiz commented Oct 27, 2025

Uh oh!

panditdhamdhere commented Oct 27, 2025

Uh oh!

ogazboiz commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mudgen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ogazboiz commented Oct 27, 2025

Uh oh!

mudgen commented Oct 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Oct 27, 2025 •

edited

Loading

mudgen left a comment •

edited

Loading

ogazboiz commented Oct 27, 2025 •

edited

Loading

ogazboiz commented Oct 27, 2025 •

edited

Loading

mudgen left a comment •

edited

Loading