feat: implement LibNonReentrancy#147
Merged
mudgen merged 3 commits intoOct 30, 2025
Merged
Conversation
Contributor
Coverage Report
Last updated: Thu, 30 Oct 2025 11:59:48 GMT for commit |
Contributor
Author
|
Just checking in regarding this PR, is there anything else to add to this PR, or does it look to merge as it is? |
mudgen
requested changes
Oct 29, 2025
mudgen
left a comment
mudgen
left a comment
Contributor
There was a problem hiding this comment.
@akronim26 Thanks for submitting this! Please review my comments.
Contributor
Author
@mudgen Thanks for reviewing. I have addressed your comments. |
Contributor
|
@akronim26 Very good! I appreciate your work here, thank you. |
JackieXu
pushed a commit
to JackieXu/Compose
that referenced
this pull request
Nov 6, 2025
…ancy-guard feat: implement LibNonReentrancy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented a LIbNonReentrant to prevent reentrancy into functions. It fixes #146
Changes Made
Implemented the functions
enter()andexit()that helps in unlocking and locking of a function.Checklist
Before submitting this PR, please ensure:
Code follows the Solidity feature ban - No inheritance, constructors, modifiers, public/private variables, external library functions,
using fordirectives, orselfdestructCode follows Design Principles - Readable, uses diamond storage, favors composition over inheritance
Code matches the codebase style - Consistent formatting, documentation, and patterns (e.g. ERC20Facet.sol)
Code is formatted with
forge fmtTests are included - All new functionality has comprehensive tests
All tests pass - Run
forge testand ensure everything worksDocumentation updated - If applicable, update relevant documentation
Make sure to follow the CONTRIBUTING.md guidelines.
Additional Notes