Fix #159 : LibERC721Enumerable.sol now set token owner during mint to resolve missing ownership #160
Merged
Merged
Conversation
…y minted tokens The mint() function in LibERC721Enumerable did not assign the new token's owner in storage (s.ownerOf[tokenId] = _to), causing minted tokens to appear non-existent and breaking transfer/burn operations. This commit adds the missing ownership assignment to align mint behavior with ERC-721 expectations and maintain enumeration consistency.
sidarth16
changed the title
sidarth16
changed the title
Contributor
Author
Test cases from #111 are now passing with this fix. |
Contributor
Coverage Report
Last updated: Fri, 31 Oct 2025 13:27:52 GMT for commit |
Contributor
Gas ReportNo gas usage changes detected between All functions maintain the same gas costs. ✅ Last updated: Fri, 31 Oct 2025 13:28:14 GMT for commit |
maxnorm
requested review from
adamgall and
mudgen
and removed request for
mudgen
JackieXu
pushed a commit
to JackieXu/Compose
that referenced
this pull request
Nov 6, 2025
Fix Perfect-Abstractions#159 : LibERC721Enumerable.sol now set token owner during mint to resolve missing ownership
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes [#159] — the bug where LibERC721Enumerable.mint() did not assign ownership for newly minted tokens. Without this assignment, the token appeared non-existent (ownerOf[tokenId] == address(0)), causing transferFrom and burn to revert.
Changes Made
s.ownerOf[_tokenId] = _to;in mint() before updating enumeration arrays.