Feature/erc1155 tests#166
Merged
Merged
Conversation
…e checks, minting, and safe transfers
Contributor
Coverage Report
Last updated: Mon, 03 Nov 2025 06:41:53 GMT for commit |
Contributor
Gas ReportNo gas usage changes detected between All functions maintain the same gas costs. ✅ Last updated: Mon, 03 Nov 2025 06:42:12 GMT for commit |
Contributor
Contributor
Author
|
Hi @mudgen |
Contributor
|
@aapsi Thanks for your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ERC1155 Test Suite Implementation
Summary
Comprehensive test suite for ERC1155 with 147 passing tests covering all ERC-1155 standard requirements.
Changes
setApprovalForAll()in lib)Test Coverage
Architecture
Harness Pattern
LibERC1155Harness.sol matches ERC721 pattern:
mint(),burn(),safeTransferFrom(), etc.setApprovalForAll(),balanceOf()Mock Implementation
ERC1155ReceiverMock.sol provides comprehensive receiver testing:
onERC1155ReceivedandonERC1155BatchReceivedTest Quality
All tests verify actual behavior:
ERC-1155 Compliance
✅ Fully compliant - ERC1155Facet correctly implements all required public interface functions with proper data parameter forwarding.
Test Results
Files
test/token/ERC1155/ERC1155/LibERC1155.t.sol
test/token/ERC1155/ERC1155/ERC1155Facet.t.sol
test/token/ERC1155/ERC1155/harnesses/LibERC1155Harness.sol
test/token/ERC1155/ERC1155/mocks/ERC1155ReceiverMock.sol
Linked Issue: #148