Skip to content

Add missing test for OwnerFacet & LibOwnerTwoStep #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxnorm merged 2 commits into from
Nov 23, 2025
Merged

Add missing test for OwnerFacet & LibOwnerTwoStep #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e37f145
add renounceOwnership test for OwnerFacet
maxnorm Nov 23, 2025
8db0d28
add missing test: direct call for renounce ownership, requireOwner vi…
maxnorm Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions test/access/Owner/OwnerFacet.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,31 @@ contract OwnerFacetTest is Test {
// Note: Zero address cannot make any calls since it has no private key
}

// ============================================
// Renounce Ownership Direct Call Tests
// ============================================

function test_RenounceOwnership_DirectCall_SetsOwnerToZero() public {
vm.prank(INITIAL_OWNER);
ownerFacet.renounceOwnership();

assertEq(ownerFacet.owner(), ZERO_ADDRESS);
}

function test_RenounceOwnership_DirectCall_EmitsEvent() public {
vm.expectEmit(true, true, false, true);
emit OwnershipTransferred(INITIAL_OWNER, ZERO_ADDRESS);

vm.prank(INITIAL_OWNER);
ownerFacet.renounceOwnership();
}

function test_RevertWhen_RenounceOwnership_CalledByNonOwner() public {
vm.expectRevert(OwnerFacet.OwnerUnauthorizedAccount.selector);
vm.prank(ALICE);
ownerFacet.renounceOwnership();
}

// ============================================
// Edge Cases
// ============================================
Expand Down
27 changes: 27 additions & 0 deletions test/access/OwnerTwoSteps/LibOwnerTwoSteps.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,33 @@ contract LibOwnerTwoStepsTest is Test {
harness.transferOwnership(ALICE);
}

function test_RenounceOwnership_DirectCall_SetsOwnerToZero() public {
vm.prank(INITIAL_OWNER);
harness.renounceOwnership();

assertEq(harness.owner(), ZERO_ADDRESS);
assertEq(harness.pendingOwner(), ZERO_ADDRESS);
}

function test_RenounceOwnership_DirectCall_EmitsEvent() public {
vm.expectEmit(true, true, false, true);
emit OwnershipTransferred(INITIAL_OWNER, ZERO_ADDRESS);

vm.prank(INITIAL_OWNER);
harness.renounceOwnership();
}

function test_RequireOwner_SucceedsForOwner() public {
vm.prank(INITIAL_OWNER);
harness.requireOwner();
}

function test_RevertWhen_RequireOwner_CalledByNonOwner() public {
vm.expectRevert(LibOwnerTwoSteps.OwnerUnauthorizedAccount.selector);
vm.prank(ALICE);
harness.requireOwner();
}

// ============================================
// Sequential Transfer Tests
// ============================================
Expand Down