Fix: Integer overflow vulnerability in recipient balance updates#32
Merged
mudgen merged 1 commit intoOct 21, 2025
Merged
Conversation
Recipient balance additions were inside unchecked blocks, allowing potential overflow attacks where an attacker could overflow a recipient's balance to zero, effectively stealing tokens. This fix moves all recipient balance additions outside unchecked blocks in both ERC20Facet and LibERC20, enabling Solidity's built-in overflow protection. Affected functions: - ERC20Facet: transfer(), transferFrom() - LibERC20: mint(), transfer(), transferFrom()
JackieXu
pushed a commit
to JackieXu/Compose
that referenced
this pull request
Nov 6, 2025
…-protection Fix: Integer overflow vulnerability in recipient balance updates
maxnorm
added a commit
that referenced
this pull request
Mar 25, 2026
[DOCS] Auto-generated Docs Pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26
Recipient balance additions were inside unchecked blocks, allowing potential overflow attacks where an attacker could overflow a recipient's balance to zero, effectively stealing tokens.
This fix moves all recipient balance additions outside unchecked blocks in both ERC20Facet and LibERC20, enabling Solidity's built-in overflow protection.
Affected functions: