Fix: Missing zero address validation in LibERC20.approve()#33
Merged
mudgen merged 1 commit intoOct 21, 2025
Merged
Conversation
The LibERC20.approve() function was missing zero address validation for the spender parameter, allowing approvals to the zero address which violates the ERC-20 standard and could lead to locked tokens. This fix adds the ERC20InvalidSpender error and validates that the spender is not the zero address, maintaining consistency with ERC20Facet.approve().
JackieXu
pushed a commit
to JackieXu/Compose
that referenced
this pull request
Nov 6, 2025
…-approve-validation Fix: Missing zero address validation in LibERC20.approve()
maxnorm
added a commit
that referenced
this pull request
Mar 25, 2026
[DOCS] Auto-generated Docs Pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27
The LibERC20.approve() function was missing zero address validation for the spender parameter, allowing approvals to the zero address which violates the ERC-20 standard and could lead to locked tokens.
This fix adds the ERC20InvalidSpender error and validates that the spender is not the zero address, maintaining consistency with ERC20Facet.approve().