Skip to content

ERC20: return bool from transfer/transferFrom/approve (EIP-20) #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mudgen merged 2 commits into from
Oct 24, 2025
Merged

ERC20: return bool from transfer/transferFrom/approve (EIP-20) #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4987be
ERC20: return bool from transfer/transferFrom/approve (EIP-20)
aapsi Oct 20, 2025
d89ec9e
update the NatSpec comments to incorporate the bool return
aapsi Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/ERC20/ERC20/ERC20Facet.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,23 +139,26 @@ contract ERC20Facet {
* @dev Emits an {Approval} event.
* @param _spender The address approved to spend tokens.
* @param _value The number of tokens to approve.
* @return True if the approval was successful.
*/
function approve(address _spender, uint256 _value) external {
function approve(address _spender, uint256 _value) external returns (bool) {
ERC20Storage storage s = getStorage();
if (_spender == address(0)) {
revert ERC20InvalidSpender(address(0));
}
s.allowances[msg.sender][_spender] = _value;
emit Approval(msg.sender, _spender, _value);
return true;
}

/**
* @notice Transfers tokens to another address.
* @dev Emits a {Transfer} event.
* @param _to The address to receive the tokens.
* @param _value The amount of tokens to transfer.
* @return True if the transfer was successful.
*/
function transfer(address _to, uint256 _value) external {
function transfer(address _to, uint256 _value) external returns (bool) {
ERC20Storage storage s = getStorage();
if (_to == address(0)) {
revert ERC20InvalidReceiver(address(0));
Expand All @@ -169,6 +172,7 @@ contract ERC20Facet {
s.balanceOf[_to] += _value;
}
emit Transfer(msg.sender, _to, _value);
return true;
}

/**
Expand All @@ -177,8 +181,9 @@ contract ERC20Facet {
* @param _from The address to transfer tokens from.
* @param _to The address to transfer tokens to.
* @param _value The amount of tokens to transfer.
* @return True if the transfer was successful.
*/
function transferFrom(address _from, address _to, uint256 _value) external {
function transferFrom(address _from, address _to, uint256 _value) external returns (bool) {
ERC20Storage storage s = getStorage();
if (_from == address(0)) {
revert ERC20InvalidSender(address(0));
Expand All @@ -200,6 +205,7 @@ contract ERC20Facet {
s.balanceOf[_to] += _value;
}
emit Transfer(_from, _to, _value);
return true;
}

/**
Expand Down