Project cleanup#324
Merged
Merged
Conversation
Changes: - Reordered header inclusions. - Changed global variable type from `char[]` to `char*` and replaced `strcpy()` of that variable to string literals assignment. - Added `-Wwrite-string` warning to build configuration to mention string literal assignments to plain `char*`. - Added `const` qualifier to `char*` assigned with string literals. - Renamed a label.
Changes: - Added local `.clang-format` file. - Made headers self-sufficient. - Avoided potential logging case in `remote_cso_loader_*` where it would log as `rezygisk-core` instead of `rezygisk-ptrace`. - Cases which are misidentified by clangd as "unused" get an IWYU pragma comment. - Reordered header inclusions using **Google style ordering**.
ThePedroo
reviewed
Apr 5, 2026
Changes: - Rearranged header inclusions according to PerformanC spec. - Reduced `execv_const` to just a `NOSONAR` comment on each case.
Changes: - Added headers where required. - Replaced a `LOGE()` call to `PLOGE()`.
Also reworked `non_blocking_execv()` to avoid a `const` qualifier drop.
ThePedroo
reviewed
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
const char*.Why
Cleaner code, better practices, less
strcpy.Checkmarks
Additional observations
In the future, consider having a file's own local header added as the first inclusion to ensure the header is self-sufficient.
E.g.:
misc.c's first line would be#include "misc.h".