fix(codegen): #142 Math.tan/asin/acos/atan/atan2 silent identity (v0.…#148
Closed
proggeramlug wants to merge 1 commit intomainfrom
Closed
fix(codegen): #142 Math.tan/asin/acos/atan/atan2 silent identity (v0.…#148proggeramlug wants to merge 1 commit intomainfrom
proggeramlug wants to merge 1 commit intomainfrom
Conversation
…5.165) The five codegen arms at crates/perry-codegen/src/expr.rs:5417-5424 fell through to lower_expr(ctx, o), returning the argument unchanged. Runtime functions (js_math_tan/asin/acos/atan/atan2 in perry-runtime/src/math.rs) and extern declarations (runtime_decls.rs:1482-1493) were already present — only the codegen wiring was missing. Replaced the fall-through with calls to the existing runtime symbols, matching the shape of the sinh/cosh/tanh arms three lines above. atan2 evaluates y first then x (JS arg order) and passes both to js_math_atan2. Verified against node --experimental-strip-types: Math.tan(1) = 1.557… (was 1), Math.atan2(0,-1) = π (was -1) — all within last-digit libm rounding.
proggeramlug
added a commit
that referenced
this pull request
Apr 23, 2026
…5.177) Merged via conflict-resolved cherry-pick of PR #148 (original branch cut at v0.5.164; main had advanced to v0.5.176 so the CLAUDE.md / Cargo.toml / Cargo.lock bumps had to be taken from main and reapplied at v0.5.177). The five codegen arms at crates/perry-codegen/src/expr.rs:5417-5424 fell through to lower_expr(ctx, o), returning the argument unchanged. Runtime functions (js_math_tan/asin/acos/atan/atan2 in perry-runtime/src/math.rs) and extern declarations (runtime_decls.rs:1482-1493) were already present — only the codegen wiring was missing. Replaced the fall-through with calls to the existing runtime symbols, matching the shape of the sinh/cosh/tanh arms three lines above. atan2 evaluates y first then x (JS arg order) and passes both to js_math_atan2. Verified against node --experimental-strip-types: Math.tan(1) = 1.557… (was 1), Math.atan2(0,-1) = π (was -1), Math.asin(1) = π/2, Math.acos(1) = 0, Math.atan(1) = π/4 — all within last-digit libm rounding. Original author: Ralph Küpper <ralph.kuepper@skelpo.com> (PR #148).
Contributor
Author
|
Merged via conflict-resolved cherry-pick as ce550d9 on main. The PR branch was cut at v0.5.164 and main had moved to v0.5.176, so the CLAUDE.md / Cargo.{toml,lock} bumps had to be reapplied at v0.5.177 on top of the intermediate changes. The actual codegen fix (the five Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…5.165)
The five codegen arms at crates/perry-codegen/src/expr.rs:5417-5424 fell through to lower_expr(ctx, o), returning the argument unchanged. Runtime functions (js_math_tan/asin/acos/atan/atan2 in perry-runtime/src/math.rs) and extern declarations (runtime_decls.rs:1482-1493) were already present — only the codegen wiring was missing.
Replaced the fall-through with calls to the existing runtime symbols, matching the shape of the sinh/cosh/tanh arms three lines above. atan2 evaluates y first then x (JS arg order) and passes both to js_math_atan2.
Verified against node --experimental-strip-types: Math.tan(1) = 1.557… (was 1), Math.atan2(0,-1) = π (was -1) — all within last-digit libm rounding.
Summary
Changes
Related issue
Test plan
cargo build --releasecleancargo test --workspace --exclude perry-ui-ios --exclude perry-ui-tvos --exclude perry-ui-watchos --exclude perry-ui-gtk4 --exclude perry-ui-android --exclude perry-ui-windowspassestest-files/or a#[test]in the affected cratedocs/src/-p perry-ui-<backend>locally on that platformScreenshots / output
Checklist
feat:/fix:/docs:/chore:prefix convention used in the log