Nativescript angular 4.4.x#138
Nativescript angular 4.4.x#138PeterStaev merged 5 commits intoPeterStaev:masterfrom jogboms:nativescript-angular-4.4.x
Conversation
|
Hey @jogboms , thanks for your contribution! I have couple of questions - do we really need to update peer-deps for TNS to be 3.3 at least? I don't see anything in the change log for 3.3 that mentioned Angular 4.4. Cant we just update the Angular deps and |
|
@PeterStaev that's true. I couldn't find one of @vakrilov's comment where he said something about a bug being fixed on the @next branch of |
| "reflect-metadata": "~0.1.8", | ||
| "rxjs": "~5.2.0", | ||
| "tns-core-modules": "3.2.0", | ||
| "tns-core-modules": "next", |
There was a problem hiding this comment.
Can this remain at 3.2.0? Or is it required to have vNext?
There was a problem hiding this comment.
Very well. Personally, i just prefer having next builds in development so i could tell if things will break before hand.
There was a problem hiding this comment.
Yes, but @next build are very unstable. There could be some TNS problem that would cause the CI builds to fail (like it failed with your first set of changes). So I prefer to stay on the stable versions. Thanks!
There was a problem hiding this comment.
Yes. True. Wondered why it failed too.
|
|
||
| "peerDependencies": { | ||
| "tns-core-modules": "^3.0.0" | ||
| "tns-core-modules": "^3.1.0 || >3.3.0-" |
There was a problem hiding this comment.
Again are we using something special from 3.1+? It is best this to remain at 3.0.0 as long as it works with the new new angular.
There was a problem hiding this comment.
nativescript-angular used the same as peer dependency.
| "grunt-exec": "2.0.0", | ||
| "nativescript-angular": "4.4.0", | ||
| "rxjs": "~5.0.1", | ||
| "tns-core-modules": "next", |
There was a problem hiding this comment.
Similar thing as above. I prefer this to remain at the least supported version so unless it needs anything from newer modules this should remain at 3.0.1.
|
@jogboms Nice PR! |
|
Couldn't tell for sure what bug it was, only remembered there was one. 😊 |
3 participants
No description provided.