[Enhancement] Remove redundant findViewById casts in example application#4018
Merged
almic merged 1 commit intoPhilJay:masterfrom May 13, 2018
Conversation
Contributor
|
Awesome, must've been a little tedious! |
regas99
pushed a commit
to regas99/MPAndroidChart
that referenced
this pull request
Apr 1, 2019
…dundant-findViewById-casts [Enhancement] Remove redundant findViewById casts in example application
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist:
Yep, opened the example app, clicked through it to see, if views initialise properly.
Modified existing ones.
This was suggested in PR 3975 that migrated the project to newest Gradle version and Gradle version plugin.
PR Description
After migration to API 26, new version of
findViewByIdmethod was added that caused, that casts to specific view instance is unnecessary. This PR removes those unnecessary casts.