[Vanilla Enhancement] Vehicle disguise to vehicle#1803
[Vanilla Enhancement] Vehicle disguise to vehicle#1803NetsuNegi wants to merge 10 commits intoPhobos-developers:developfrom
Conversation
NetsuNegi
added
❓New feature
Needs testing
⚙️T1
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
CrimRecya
left a comment
CrimRecya
left a comment
There was a problem hiding this comment.
There is a problem that could lead to a crash.
Others look good, and I think we can make them clearer.
And, I'm not sure if there's anything else that need to process.
NetsuNegi
force-pushed
the
origin/feature/vehicle_disguise
branch
from
bdd7977 to
071e418
Compare
Tested by 
|
NetsuNegi
force-pushed
the
origin/feature/vehicle_disguise
branch
from
a5f2ea4 to
283baf2
Compare
src/Ext/Techno/Hooks.Misc.cpp
Outdated
| return 0; | ||
| } | ||
|
|
||
| DEFINE_JUMP(LJMP, 0x706724, 0x706731); |
There was a problem hiding this comment.
Should give comment for JUMP, since it has no name.
There was a problem hiding this comment.
I forgot what it dose
|
|
||
| if (pTargetType && pTargetType->Turret) | ||
| { | ||
| R->ESI(&pThis->PrimaryFacing); |
There was a problem hiding this comment.
I think it might be more appropriate to let the disguiser use the disguised type in UpdateRotating(0x736990)?
There was a problem hiding this comment.
no, this it deal with non turret vehicle
NetsuNegi
force-pushed
the
origin/feature/vehicle_disguise
branch
from
fc12d31 to
641546b
Compare
4 participants
In
rulesmd.ini: