Skip to content

Fixed an issue that retaliation will make the unit keep switching among multiple targets with the same amount of threat#2075

Merged
Coronia merged 2 commits intoPhobos-developers:developfrom
TaranDahl:RetaliateThreatBugFix
Jan 31, 2026
Merged

Fixed an issue that retaliation will make the unit keep switching among multiple targets with the same amount of threat#2075
Coronia merged 2 commits intoPhobos-developers:developfrom
TaranDahl:RetaliateThreatBugFix

Conversation

@TaranDahl
Copy link
Copy Markdown
Contributor

No description provided.

@TaranDahl TaranDahl added ❓Vanilla bug Vanilla game bugs that are requested to be fixed Needs testing ⚙️T1 T1 maintainer review is sufficient Bugfix This is a bugfix that does not need documentation beyond mention in changelog labels Jan 30, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 30, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Copy link
Copy Markdown
Contributor

@Coronia Coronia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codes look fine but not sure how to test it

@TaranDahl
Copy link
Copy Markdown
Contributor Author

how to test it

  1. Set all the threat xxxxcoefficient to zero.
  2. Gather a group of E1 to attack one AI HTNK.

In vanilla the HTNK will continuously rotate its turret and fire at different targets.
With this fix, it should fire at one target to death.

@Coronia Coronia merged commit 5bc8f11 into Phobos-developers:develop Jan 31, 2026
12 checks passed
@TaranDahl TaranDahl deleted the RetaliateThreatBugFix branch January 31, 2026 15:49
@mevitar
Copy link
Copy Markdown

mevitar commented Feb 1, 2026

I've noticed this issue when testing delayed fire logic, as AI units kept resetting their targets everytime they got shot at, and thus be unable to actually attack anything when under constant fire. Same problem happened with FireUp=, for infantry or vehicles.

It is indeed fixed now.

DeathFishAtEase added a commit to DeathFishAtEase/Phobos that referenced this pull request Feb 1, 2026
DeathFishAtEase added a commit to DeathFishAtEase/Phobos that referenced this pull request Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This is a bugfix that does not need documentation beyond mention in changelog ⚙️T1 T1 maintainer review is sufficient Tested ❓Vanilla bug Vanilla game bugs that are requested to be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants