Separate AI naval vehicle production from regular vehicle production#817
Conversation
|
Nightly build for this pull request:
|
Starkku
force-pushed
the
feature/ai-naval-production-fix
branch
from
66ddb19 to
3fa2d71
Compare
|
I tested it and works as expected. It respects the Ares tag "[GlobalControls] -> AllowParallelAIQueues" |
Starkku
force-pushed
the
feature/ai-naval-production-fix
branch
2 times, most recently
from
ff59549 to
d2f48ce
Compare
|
There is an issue of yet undetermined cause that sometimes crashes the game due to a seemingly corrupt |
|
The crash mentioned in my previous comment should now be fixed. |
Starkku
force-pushed
the
feature/ai-naval-production-fix
branch
from
d595b16 to
f7f7386
Compare
|
I would like to test this but it appears the link has expired. |
Starkku
force-pushed
the
feature/ai-naval-production-fix
branch
from
5819c42 to
b0628bf
Compare
Starkku
force-pushed
the
feature/ai-naval-production-fix
branch
from
b0628bf to
3f4c6b2
Compare
The service that provides the links seems to work slowly or not at all right now, can still get the download manually from the commit's action summary. Step 1 https://github.com/Phobos-developers/Phobos/suites/12832730234/artifacts/691258980 |
DOOMGUY2K
left a comment
DOOMGUY2K
left a comment
There was a problem hiding this comment.
I can confirm this is working as intended.
I checked the previous notes
Tested on
Vanilla 1.001
Ares 3.01p
And KratosDP
And combined inside my own Mod.
…hobos-developers#817) * Separate AI naval vehicle production from regular vehicle production * Fixup * Adjust a hook * Fix a broken hook return address causing a crash * Split the vehicle production update code * Fix minor style issues * shut 🦆👌 --------- Co-authored-by: Kerbiter <crabiter@vivaldi.net>
4 participants
By default, while game has separate FactoryClass instances and queues for regular and naval vehicles, game still keeps track of which VehicleType to build and which one was last built using only one reference each in HouseClass. This PR decouples this for ground and naval vehicles, allowing AI to produce both simultaneously.
Because Ares reimplements the HouseClass unit production update function (
0x4FEA60) and this feature/fix is impossible to implement without touching that function, it has been reimplemented here again using Ares 0.A version of the function as a reference. However as it stands, I have no reliable way of telling if it has been altered to any significant degree in time since that and 3.0. It is possible that this PR uses less optimized code, or in worst-case, faulty or partial. I would appreciate help of a more experienced reverse-engineer with this.