Skip to content

Refactor the "vcrun2003" Verb Script #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madoar merged 1 commit into from
Aug 18, 2019
Merged

Refactor the "vcrun2003" Verb Script #1087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions Engines/Wine/Verbs/vcrun2003/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const Wine = include("engines.wine.engine.object");
const Resource = include("utils.functions.net.resource");
const {cp} = include("utils.functions.filesystem.files");
const { cp } = include("utils.functions.filesystem.files");

include("engines.wine.verbs.luna");

Expand All @@ -10,7 +10,7 @@ include("engines.wine.verbs.luna");
* @returns {Wine} Wine object
*/
Wine.prototype.vcrun2003 = function () {
var setupFile = new Resource()
const setupFile = new Resource()
.wizard(this.wizard())
.url("https://sourceforge.net/projects/bzflag/files/bzedit%20win32/1.6.5/BZEditW32_1.6.5.exe")
.checksum("bdd1b32c4202fd77e6513fd507c8236888b09121")
Expand All @@ -20,14 +20,10 @@ Wine.prototype.vcrun2003 = function () {
this.wizard().wait(tr("Please wait while {0} is installed...", "Microsoft Visual C++ 2003 Redistributable (x86)"));
this.run(setupFile, "/S", null, false, true);

var dlls = [
"msvcp71",
"mfc71"
];
const dlls = ["msvcp71", "mfc71"];

var that = this;
dlls.forEach(function (dll) {
cp(that.programFiles() + "/BZEdit1.6.5/" + dll, this.system32directory());
dlls.forEach(dll => {
Copy link
Copy Markdown
Collaborator

@plata plata Aug 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to make Codacy find the places where function() is used instead of =>?

Copy link
Copy Markdown
Collaborator Author

@madoar madoar Aug 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think https://eslint.org/docs/rules/prefer-arrow-callback does what you want

Copy link
Copy Markdown
Collaborator

@plata plata Aug 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to try it?

cp(this.programFiles() + "/BZEdit1.6.5/" + dll, this.system32directory());
});

return this;
Expand All @@ -36,18 +32,21 @@ Wine.prototype.vcrun2003 = function () {
/**
* Verb to install vcrun2003
*/
// eslint-disable-next-line no-unused-vars
module.default = class Vcrun2003Verb {
constructor() {
// do nothing
}

install(container) {
var wine = new Wine();
const wine = new Wine();

wine.prefix(container);
var wizard = SetupWizard(InstallationType.VERBS, "vcrun2003", java.util.Optional.empty());

const wizard = SetupWizard(InstallationType.VERBS, "vcrun2003", java.util.Optional.empty());

wine.wizard(wizard);
wine.vcrun2003();

wizard.close();
}
}
};