Skip to content

Age of Empires II HD: skip broken launcher#234

Merged
plata merged 1 commit intoPhoenicisOrg:masterfrom
plata:aoe2hd
May 21, 2017
Merged

Age of Empires II HD: skip broken launcher#234
plata merged 1 commit intoPhoenicisOrg:masterfrom
plata:aoe2hd

Conversation

@plata
Copy link
Copy Markdown
Collaborator

@plata plata commented May 6, 2017

fixes #233

@madoar
Copy link
Copy Markdown
Collaborator

madoar commented May 21, 2017

I would suggest to add the fact that you're skipping the launcher when running AoE 2 everytime your start the application to the description. Otherwise this seems ready to be merged for me.

@plata
Copy link
Copy Markdown
Collaborator Author

plata commented May 21, 2017

I don't think that's possible: Skipping the launcher is depending on the script (we might have several), whereas the description belongs to the application.

@madoar
Copy link
Copy Markdown
Collaborator

madoar commented May 21, 2017

Could we maybe add a hint field to the scripts? If this hint field is defined (not null) we show a yellow message with an attention mark in POL 5 for this script, that describes what the user should be aware of when installing the script?

@plata
Copy link
Copy Markdown
Collaborator Author

plata commented May 21, 2017

We could do that, but then again you could just open a message in the wizard directly.

@madoar
Copy link
Copy Markdown
Collaborator

madoar commented May 21, 2017

The idea with the hint field is mainly to make the user aware of possible hazards when selecting the script, especially if there are more then one possible script for an application.

@plata
Copy link
Copy Markdown
Collaborator Author

plata commented May 21, 2017

I see. Not really sure if this is a good idea however (thinking about the presentation in the GUI). We can think about it but then we should open a new issue for this (it's out of scope for this PR).

@madoar
Copy link
Copy Markdown
Collaborator

madoar commented May 21, 2017

That's true, where should we open such an issue?
We can merge this PR then.

@plata
Copy link
Copy Markdown
Collaborator Author

plata commented May 21, 2017

I would suggest PlayOnLinux/POL-POM-5 (after we have thought about the presentation, we can tackle the scripts part).

@plata plata merged commit 30558f4 into PhoenicisOrg:master May 21, 2017
@plata plata deleted the aoe2hd branch May 21, 2017 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Age of Empires II HD doesn't load without launcher rename

2 participants