Skip to content

validate: testingOperatingSystems must be a subset of compatibleOperatingSystems #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plata merged 3 commits into from
Mar 15, 2018
Merged

validate: testingOperatingSystems must be a subset of compatibleOperatingSystems #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
061e61e
validate: testingOperatingSystems must be a subset of compatibleOpera…
plata Mar 15, 2018
6bac5ce
doesn't have to be a true subset
plata Mar 15, 2018
a2ab2fc
fixed incorrect script.json files
plata Mar 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Applications/Games/Assassin's Creed: Brotherhood/Steam/script.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"scriptName": "Steam",
"compatibleOperatingSystems": ["LINUX"],
"compatibleOperatingSystems": ["MACOSX", "LINUX"],
"testingOperatingSystems": ["MACOSX"],
"free": false,
"requiresPatch": false
Expand Down
2 changes: 1 addition & 1 deletion Applications/Games/Far Cry 3 - Blood Dragon/Uplay/script.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"scriptName": "Uplay",
"compatibleOperatingSystems": [],
"compatibleOperatingSystems": ["LINUX"],
"testingOperatingSystems": ["LINUX"],
"free": false,
"requiresPatch": false
Expand Down
2 changes: 1 addition & 1 deletion Applications/Games/PAYDAY The Heist/Steam/script.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"scriptName": "Steam",
"compatibleOperatingSystems": ["LINUX"],
"compatibleOperatingSystems": ["MACOSX", "LINUX"],
"testingOperatingSystems": ["MACOSX"],
"free": false,
"requiresPatch": false
Expand Down
4 changes: 4 additions & 0 deletions validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,10 @@
with open(script_json_file) as f:
script_json = json.loads(f.read().decode("utf-8-sig"))
jsonschema.validate(script_json, script_schema)
# check that testingOperatingSystems is a subset of compatibleOperatingSystems
if not set(script_json['testingOperatingSystems']) <= set(script_json['compatibleOperatingSystems']):
print "{}: testingOperatingSystems must be a subset of compatibleOperatingSystems".format(script_json_file)
is_valid = False
except ValueError as value_error:
print "invalid script.json {}: {}".format(script_json_file, value_error)
is_valid = False
Expand Down