Skip to content

Fix ESLint "no-redeclare" warnings #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plata merged 6 commits into from
Mar 28, 2018
Merged

Fix ESLint "no-redeclare" warnings #532

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d55095c
d3dx10
plata Mar 27, 2018
895f493
d3dx9
plata Mar 27, 2018
fed7dd3
secur32
plata Mar 27, 2018
5561856
xact
plata Mar 27, 2018
1e916f1
InstallerScript
plata Mar 27, 2018
93947ec
Fix undefined
plata Mar 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
InstallerScript
  • Loading branch information
@plata
plata authored Mar 27, 2018
commit 1e916f168437904d171d1eb81fe932c0a52c0172
12 changes: 6 additions & 6 deletions Engines/Wine/QuickScript/InstallerScript/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ InstallerScript.prototype.go = function() {

var distributions = wine.availableDistributions();
var shownDistributions = [];
for (var i in distributions) {
if (distributions[i] == "upstream") {
for (var distributionIdx in distributions) {
if (distributions[distributionIdx] == "upstream") {
shownDistributions.push("upstream (recommended)");
}
else {
shownDistributions.push(distributions[i]);
shownDistributions.push(distributions[distributionIdx]);
}
}
var selectedDistribution = setupWizard.menu(tr("Please select the wine distribution."), shownDistributions, "upstream (recommended)");
Expand All @@ -55,12 +55,12 @@ InstallerScript.prototype.go = function() {

var versions = wine.availableVersions();
var shownVersions = [];
for (var i in versions) {
if (versions[i] == LATEST_STABLE_VERSION) {
for (var versionIdx in versions) {
if (versions[versionIdx] == LATEST_STABLE_VERSION) {
shownVersions.push(versions[i] + " (recommended)");
}
else {
shownVersions.push(versions[i]);
shownVersions.push(versions[versionIdx]);
}
}
var selectedVersion = setupWizard.menu(tr("Please select the wine version."), shownVersions, LATEST_STABLE_VERSION + " (recommended)");
Expand Down