Skip to content

Update SteamScript (fix Steam browser and Uplay rendering issues) #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImperatorS79 merged 6 commits into from
Jun 7, 2019
Merged

Update SteamScript (fix Steam browser and Uplay rendering issues) #979

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fdd5067
Fix for steam quickscript
Jun 6, 2019
5f8cf90
Added include for corefonts
Jun 6, 2019
9ac4f73
Added include for windows_version
Jun 6, 2019
fb996d2
Fix for corefonts syntax, imperator was right dammit!
Jun 6, 2019
b81bb19
Fixed indentation
Jun 6, 2019
0cc166c
Added fix for Uplay games on steam
Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Engines/Wine/QuickScript/Steam Script/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ include("engines.wine.plugins.override_dll");
include("utils.functions.filesystem.extract");
include("utils.functions.filesystem.files");
include("engines.wine.verbs.luna");
include("engines.wine.verbs.corefonts");
include("engines.wine.plugins.windows_version");


function SteamScript() {
Expand Down Expand Up @@ -116,11 +118,20 @@ SteamScript.prototype.go = function () {
.wizard(setupWizard)
.prefix(this._name, this._wineDistribution, this._wineArchitecture, this._wineVersion)
.luna();
wine.corefonts();

// Steam must be started once such that config.vdf is created (see fixCertificateIssue())
setupWizard.wait(tr("Please follow the steps of the Steam setup. Then, wait until Steam is updated, log in and finally close Steam completely so the installation of \"{0}\" can continue.", this._name));
wine.run(tempFile, [], null, false, true);

// Set windows environment for executable that needs it
wine.setOsForApplication().set("steam.exe", "winxp").do();
wine.setOsForApplication().set("steamwebhelper.exe", "winxp").do();
Comment thread
Kreyren marked this conversation as resolved.

// Fix for Uplay games that are executed on steam
wine.setOsForApplication().set("upc.exe", "winvista").do();
Copy link
Copy Markdown
Contributor

@ImperatorS79 ImperatorS79 Jun 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plata Should we set it here ? It is a simple way to do IMHO ^^.

Copy link
Copy Markdown
Contributor Author

@Kreyren Kreyren Jun 6, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ImperatorS79 how else you want to do it assuming that we are not using quick uplay nor uplay script in quick steam script

Copy link
Copy Markdown
Contributor

@ImperatorS79 ImperatorS79 Jun 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could chose it is not the responsibility of SteamScript to handle it and for any Steamapps using Uplay you had to set it in the .preInstall. But I think your solution is clean.

Copy link
Copy Markdown
Contributor Author

@Kreyren Kreyren Jun 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ImperatorS79 I'm for sanitization your suggestion is better, proceed.

Copy link
Copy Markdown
Collaborator

@plata plata Jun 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't hurt. I'm not sure about the "steamwebhelper.exe". Does this really work still?

Copy link
Copy Markdown
Contributor Author

@Kreyren Kreyren Jun 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plata

I'm not sure about the "steamwebhelper.exe". Does this really work still?

Works on my system (tm)

wine.setOsForApplication().set("UbisoftGameLauncher.exe", "winvista").do();

// ensure that Steam is running (user might have unchecked "run Steam after installation finished")
wine.runInsidePrefix(wine.programFiles() + "/Steam/Steam.exe", ["steam://nav/games"], false);

Expand Down