Skip to content

cleanups for demo for tutorial - #3

Merged
henningkayser merged 1 commit into
PickNikRobotics:demo_for_tutorialfrom
ubi-agni:demo_for_tutorial
Oct 7, 2019
Merged

cleanups for demo for tutorial#3
henningkayser merged 1 commit into
PickNikRobotics:demo_for_tutorialfrom
ubi-agni:demo_for_tutorial

Conversation

@rhaschke

@rhaschke rhaschke commented Sep 30, 2019

Copy link
Copy Markdown

Unfortunately, I was not able to push my cleanup changes to moveit#104 directly. For this reason, I file them here.
@henningkayser, please have a look and merge them. With those changes, I approve moveit#104.

@rhaschke
cleanup
aee68e5 
- fix dependencies
  - moveit_visual_tools is not actually used
  - panda_moveit_config is required in a recent version
- use more specific lib/binary names
@rhaschke rhaschke mentioned this pull request Sep 30, 2019
Merged
@rhaschke

rhaschke commented Oct 5, 2019

Copy link
Copy Markdown
Author

Ping @henningkayser.

@henningkayser
henningkayser merged commit 2bd2826 into PickNikRobotics:demo_for_tutorial Oct 7, 2019
@rhaschke
rhaschke deleted the demo_for_tutorial branch October 8, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@henningkayser henningkayser henningkayser approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rhaschke @henningkayser