twist_controller -> picknik_twist_controller - #3
Merged
Conversation
1. prefix twist_controller with picknik_twist_controller When we merge twist_controller into ros2_controllers we can depricate this one and not have naming conflicts as users migrate Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Codecov Report
@@ Coverage Diff @@
## main #3 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 1
Lines ? 56
Branches ? 0
======================================
Hits ? 0
Misses ? 56
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MarqRazz
reviewed
Jun 20, 2023
Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
bump to oldest version used on Ubuntu Focal + ROS 2 Humble https://www.ros.org/reps/rep-2000.html#humble-hawksbill-may-2022-may-2027 Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
abake48
reviewed
Jun 20, 2023
abake48
approved these changes
Jun 20, 2023
moriarty
added a commit
to moriarty/rosdistro
that referenced
this pull request
Jul 11, 2023
Increasing version of package(s) in repository `picknik_controllers` to `0.0.1-1`: - upstream repository: https://github.com/PickNikRobotics/picknik_controllers.git - release repository: https://github.com/ros2-gbp/picknik_controllers-release.git - distro file: `rolling/distribution.yaml` - bloom version: `0.11.2` - previous version for package: `null` ``` * Initial Release of picknik_reset_fault_controller * Originally this was used internally and there was an attempt to release it to ros2_controllers * After discussion with the ros2 controllers WG over slack we have decided to open source it here first * The goal is to still move this upstream but it can be worked on here first and moved in the future * fault_controller -> picknik_reset_fault_controller (ros#2 <PickNikRobotics/picknik_controllers#2>) * fault_controller -> picknik_reset_fault_controller This commit does two things: 1) renames fault_controller to reset_fault_controller 2) prefixes with picknik_ The first change, is to be more specific what this controller is used for. The second change is because we want to move this controller into ros2_controllers and when that is complete we can drop the picknik_ and depricate this version allowing for a transition period. --------- * Contributors: Alexander Moriarty @moriarty, Anthony Baker @abake48, @livanov93, @destogl, @MarqRazz, @Abishalini, @JafarAbdi ``` ``` * Initial Release of picknik_twist_controller * Originally this was used internally and there was an attempt to release it to ros2_controllers here: ros-controls/ros2_controllers#300 * The goal is to still move this upstream but it needs to be refactored before going upstream. * twist_controller -> picknik_twist_controller (ros#3 <PickNikRobotics/picknik_controllers#3>) * twist_controller -> picknik_twist_controller 1. prefix twist_controller with picknik_twist_controller When we merge twist_controller into ros2_controllers we can depricate this one and not have naming conflicts as users migrate * cmake: 3.8 -> 3.16 bump to oldest version used on Ubuntu Focal + ROS 2 Humble https://www.ros.org/reps/rep-2000.html#humble-hawksbill-may-2022-may-2027 --------- * Contributors: Alexander Moriarty @moriarty, Anthony Baker @abake48, @livanov93, @destogl, @MarqRazz, @Abishalini, @JafarAbdi ``` Signed-off-by: Alexander Moriarty <alex.moriarty@picknik.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we merge twist_controller into ros2_controllers we can depricate this one and not have naming conflicts as users migrate