Don't break multi-line strings - #14
Merged
Merged
Conversation
`AlwaysBreakBeforeMultilineStrings: false` will make the following
change, causing howls. Setting it `true` didn't make any difference
on other parts of code (it won't try to recombine multi-line strings).
-const std::unordered_map<uint, std::string> BLAH_BLAH_MAP(
- { { ITEM_UNO, "Lorem ipsum dolor sit amet, consectetur adipiscing" },
- { ITEM_DOS_SUPER_DUPER_YUCK,
- "Sed ut perspiciatis unde omnis iste natus error sit voluptatem accusantium "
- "doloremque" },
- [...]
+const std::unordered_map<uint, std::string> BLAH_BLAH_MAP({ { ITEM_UNO, "Lorem ipsum dolor sit amet, consectetur "
+ "adipiscing" },
+ { ITEM_DOS_SUPER_DUPER_YUCK, "Sed ut perspiciatis "
+ "unde omnis iste natus "
+ "error sit voluptatem "
+ "accusantium" },
+ [...]
This was referenced Sep 20, 2020
andyz/squashed_improvements branch, merged w/master,
clang tests fixed
PickNikRobotics/trackjoint#63
Merged
Member
|
@rhaschke do you think this change makes sense for ROS 1 clang format? |
|
The key issue here is that the So, both approaches have their pros and cons. I don't really care. |
davetcoleman
approved these changes
Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AlwaysBreakBeforeMultilineStrings: falsewill make the followingchange, causing howls. Setting it
truedidn't make any differenceon other parts of code (it won't try to recombine multi-line strings).