Skip to content

Fix AddChannel parameters to accept constant strings - #7

Merged
PlutoUser merged 1 commit into
PlutoUser:masterfrom
rlalik:fix_decay_channels
Jun 23, 2023
Merged

Fix AddChannel parameters to accept constant strings#7
PlutoUser merged 1 commit into
PlutoUser:masterfrom
rlalik:fix_decay_channels

Conversation

@rlalik

@rlalik rlalik commented Jun 22, 2023

Copy link
Copy Markdown
Contributor

It adds const cv-specifier to the ids parameter to accept also const char literals.
My editor also fixes trailing white spaces.
I will not be able to fix other PR without this being accepted first.

@PlutoUser

Copy link
Copy Markdown
Owner

Could you change Editor settings. We can make cosmetic changes later. At the moment I cannot work like this.

@PlutoUser

Copy link
Copy Markdown
Owner

Or make one dedicated merge request first where you clean up all files first so that one can see the important lines later

@rlalik

rlalik commented Jun 23, 2023

Copy link
Copy Markdown
Contributor Author

What do you think about using clang-format to format whole code in consistent style which can be later also applied to any new file/change (e.g. make format-fix to format all files before commit)? You could choose your preferred style among many: https://clang.llvm.org/docs/ClangFormatStyleOptions.html#configurable-format-style-options

Each style can be additionally customized, I usually use e.g. this one:

BasedOnStyle: LLVM
UseTab: Never
IndentWidth: 4
BreakBeforeBraces: Allman
AllowShortBlocksOnASingleLine: true
AllowShortIfStatementsOnASingleLine: true
IndentCaseLabels: true
ColumnLimit: 120
PointerAlignment: Left
AccessModifierOffset: -4
TabWidth: 4

and here an example file: https://github.com/rlalik/HelloFitty/blob/master/include/hellofitty.hpp
There are many customisable options and finding the optimal style sometime takes several try&check shots. But just go through options and choose the one you like.
GSI does not provide clang-format, I always use it on my local machine where I can configure my full toolchain.

@PlutoUser

Copy link
Copy Markdown
Owner

I think you have to pull from the master of this repo to get rid of the unneeded changes and to solve to conflict

@rlalik
rlalik force-pushed the fix_decay_channels branch from 11eb33a to 1ccec06 Compare June 23, 2023 15:30
@PlutoUser
PlutoUser merged commit af81317 into PlutoUser:master Jun 23, 2023
@rlalik rlalik mentioned this pull request Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants