Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions data/v2/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -2212,6 +2212,26 @@ def csv_record_to_objects(info):

build_generic((PokemonFormType,), "pokemon_form_types.csv", csv_record_to_objects)

def csv_record_to_objects(info):
yield PokemonFormTrigger(id=int(info[0]), name=info[1])

build_generic(
(PokemonFormTrigger,), "pokemon_form_triggers.csv", csv_record_to_objects
)

def csv_record_to_objects(info):
yield PokemonFormCondition(
pokemon_form_id=int(info[0]),
form_trigger_id=int(info[1]),
item_id=int(info[2]) if info[2] != "" else None,
ability_id=int(info[3]) if info[3] != "" else None,
move_id=int(info[4]) if info[4] != "" else None,
)

build_generic(
(PokemonFormCondition,), "pokemon_form_conditions.csv", csv_record_to_objects
)

def csv_record_to_objects(info):
yield PokemonGameIndex(
pokemon_id=int(info[0]), version_id=int(info[1]), game_index=int(info[2])
Expand Down
47 changes: 46 additions & 1 deletion data/v2/csv/items.csv
Original file line number Diff line number Diff line change
Expand Up @@ -2174,4 +2174,49 @@ id,identifier,category_id,cost,fling_power,fling_effect_id
2229,laorigin-ball,34,0,,
2230,black-augurite,10,0,,
2231,peat-block,10,0,,
2232,metal-alloy,10,0,,
2232,metal-alloy,10,0,,
2233,clefablite,44,0,80,
2234,victreebelite,44,0,80,
2235,starminite,44,0,80,
2236,dragoninite,44,0,80,
2237,meganiumite,44,0,80,
2238,feraligite,44,0,80,
2239,skarmorite,44,0,80,
2240,froslassite,44,0,80,
2241,heatranite,44,0,80,
2242,darkranite,44,0,80,
2243,emboarite,44,0,80,
2244,excadrite,44,0,80,
2245,scolipite,44,0,80,
2246,scraftinite,44,0,80,
2247,eelektrossite,44,0,80,
2248,chandelurite,44,0,80,
2249,chesnaughtite,44,0,80,
2250,delphoxite,44,0,80,
2251,greninjite,44,0,80,
2252,pyroarite,44,0,80,
2253,floettite,44,0,80,
2254,malamarite,44,0,80,
2255,barbaracite,44,0,80,
2256,dragalgite,44,0,80,
2257,hawluchanite,44,0,80,
2258,zygardite,44,0,80,
2259,drampanite,44,0,80,
2260,zeraorite,44,0,80,
2261,falinksite,44,0,80,
2262,raichunite-x,44,0,80,
2263,raichunite-y,44,0,80,
2264,chimechite,44,0,80,
2265,absolite-z,44,0,80,
2266,staraptite,44,0,80,
2267,garchompite-z,44,0,80,
2268,lucarionite-z,44,0,80,
2269,golurkite,44,0,80,
2270,meowsticite,44,0,80,
2271,crabominite,44,0,80,
2272,golisopite,44,0,80,
2273,magearnite,44,0,80,
2274,scovillainite,44,0,80,
2275,baxcalibrite,44,0,80,
2276,tatsugirinite,44,0,80,
2277,glimmoranite,44,0,80,
224 changes: 224 additions & 0 deletions data/v2/csv/pokemon_form_conditions.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,224 @@
pokemon_form_id,form_trigger_id,trigger_item_id,trigger_ability_id,trigger_move_id
493,1,1662,,
681,4,,176,
718,1,884,,
741,2,889,,
1017,1,2102,,
10028,4,,59,
10029,4,,59,
10030,4,,59,
10038,4,,122,
10041,1,285,,
10042,1,289,,
10043,1,288,,
10044,1,277,,
10045,1,280,,
10046,1,275,,
10047,1,283,,
10048,1,287,,
10049,1,278,,
10050,1,282,,
10051,1,279,,
10052,1,281,,
10053,1,284,,
10054,1,286,,
10055,1,290,,
10056,1,276,,
10063,1,442,,
10063,1,1661,,
10064,3,444,,
10067,4,,161,
10074,6,,,547
10075,1,563,,
10076,1,564,,
10077,1,565,,
10078,1,566,,
10079,3,681,,
10080,3,681,,
10081,3,681,,
10084,6,,,548
10085,1,684,,
10125,4,,176,
10133,1,698,,
10134,1,699,,
10135,1,717,,
10136,1,700,,
10137,1,718,,
10138,1,695,,
10139,1,714,,
10140,1,710,,
10141,1,715,,
10142,1,711,,
10143,1,701,,
10144,1,702,,
10145,1,697,,
10146,1,709,,
10147,1,719,,
10148,1,705,,
10149,1,708,,
10150,1,703,,
10151,1,696,,
10152,1,720,,
10153,1,706,,
10154,1,704,,
10155,1,721,,
10156,1,707,,
10157,1,716,,
10158,1,722,,
10159,1,712,,
10160,1,713,,
10164,1,760,,
10165,1,761,,
10166,1,793,,
10167,1,794,,
10168,1,795,,
10169,1,796,,
10170,1,797,,
10171,1,798,,
10172,1,800,,
10173,1,801,,
10174,1,802,,
10175,1,803,,
10176,1,804,,
10177,1,805,,
10178,1,799,,
10179,1,468,,
10180,1,467,,
10188,3,806,,
10189,1,808,,
10190,1,809,,
10191,1,810,,
10192,1,811,,
10219,4,,210,
10220,1,884,,
10221,1,884,,
10222,4,,211,
10225,2,890,,
10226,2,891,,
10227,2,892,,
10229,4,,208,
10232,1,902,,
10233,1,903,,
10234,1,904,,
10235,1,905,,
10236,1,906,,
10237,1,907,,
10238,1,908,,
10239,1,909,,
10240,1,910,,
10241,1,911,,
10242,1,912,,
10243,1,913,,
10244,1,914,,
10245,1,915,,
10246,1,916,,
10247,1,917,,
10248,1,918,,
10255,4,,197,
10256,4,,197,
10257,4,,197,
10258,4,,197,
10259,4,,197,
10260,4,,197,
10261,4,,197,
10262,4,,209,
10264,4,,209,
10337,4,,161,
10340,1,884,,
10341,4,,241,
10342,4,,241,
10354,4,,248,
10356,4,,258,
10357,1,1161,,
10358,1,1162,,
10364,5,,,
10365,5,,,
10366,5,,,
10367,5,,,
10368,5,,,
10369,5,,,
10370,5,,,
10371,5,,,
10372,5,,,
10373,5,,,
10374,5,,,
10375,5,,,
10376,5,,,
10377,5,,,
10378,5,,,
10379,5,,,
10380,5,,,
10381,5,,,
10382,5,,,
10383,5,,,
10384,5,,,
10385,5,,,
10386,5,,,
10387,5,,,
10388,5,,,
10389,5,,,
10390,5,,,
10391,5,,,
10392,5,,,
10393,5,,,
10394,5,,,
10395,5,,,
10396,5,,,
10397,5,,,
10414,1,1659,,
10415,1,1660,,
10425,4,,278,
10442,1,2106,,
10443,1,2107,,
10444,1,2108,,
10445,4,,304,
10446,3,1669,,
10503,1,2233,,
10504,1,2234,,
10505,1,2235,,
10506,1,2236,,
10507,1,2237,,
10508,1,2238,,
10509,1,2239,,
10510,1,2240,,
10511,1,2243,,
10512,1,2244,,
10513,1,2245,,
10514,1,2246,,
10515,1,2247,,
10516,1,2248,,
10517,1,2249,,
10518,1,2250,,
10519,1,2251,,
10520,1,2252,,
10521,1,2253,,
10522,1,2254,,
10523,1,2255,,
10524,1,2256,,
10525,1,2257,,
10526,1,2258,,
10527,1,2259,,
10528,1,2261,,
10529,1,2262,,
10530,1,2263,,
10531,1,2264,,
10532,1,2265,,
10533,1,2266,,
10534,1,2267,,
10535,1,2268,,
10536,1,2241,,
10537,1,2242,,
10538,1,2269,,
10539,1,2270,,
10540,1,2271,,
10541,1,2272,,
10542,1,2273,,
10543,1,2273,,
10544,1,2260,,
10545,1,2274,,
10546,1,2277,,
10547,1,2276,,
10548,1,2276,,
10549,1,2276,,
10550,1,2275,,
10554,1,2270,,
7 changes: 7 additions & 0 deletions data/v2/csv/pokemon_form_trigger_prose.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
pokemon_form_trigger_id,local_language_id,name
1,9,Held item
2,9,Consumed item
3,9,Key item
4,9,Ability
5,9,Gigantamax factor
6,9,Move
7 changes: 7 additions & 0 deletions data/v2/csv/pokemon_form_triggers.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
id,identifier

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add a pokemon_form_method_prose.csv file to match

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the pokemon_form_trigger_prose.csv the one you are referring to?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that’s the one that was added, there was some renaming done

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, just a silly idea. What about using the evolution_trigger.csv file here? Some triggers are already shared, for example move or consumed-item. @dyp1109 @jemarq04 do you think it can get messy?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I think we should make a new endpoint for clarity, as there are evolution triggers that wouldn’t work as form triggers

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a clear distinction between form changes and evolution. Form changes are temporary, while evolution is permanent. While that might not be a perfect definition, we should try to separate the two situations as much as possible.

1,held-item
2,consumed-item
3,key-item
4,ability
5,gigantamax-factor
6,move
Loading
Loading