Skip to content

Remove zone prefix#1579

Merged
Naramsim merged 1 commit into
masterfrom
staging
Jul 3, 2026
Merged

Remove zone prefix#1579
Naramsim merged 1 commit into
masterfrom
staging

Conversation

@Naramsim

@Naramsim Naramsim commented Jul 2, 2026

Copy link
Copy Markdown
Member

Change description

addressing the comment:

When reviewing the encounters, I did notice that the location areas are named a bit silly so we get things like johto-safari-zone-zone-desert with 'zone' repeated. If you'd be willing, could you rename these location areas (813-824) to either remove 'zone' or move it to the end? Up to you how to do it!

@jemarq04 can you check if the removal is any good? You can use https://staging.pokeapi.co/api/v2/ in an hour or so. The cicd is still running and it hasnt' deployed it yet.

AI coding assistance disclosure

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

pokeapi-machine-user added a commit to PokeAPI/api-data that referenced this pull request Jul 2, 2026

@jemarq04 jemarq04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good!

@Naramsim Naramsim merged commit 6629d15 into master Jul 3, 2026
11 checks passed
@pokeapi-machine-user

Copy link
Copy Markdown

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user

Copy link
Copy Markdown

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants