Add Sword/Shield encounters (Part 4: Northern Wild Areas)#1581
Open
jemarq04 wants to merge 31 commits into
Open
Add Sword/Shield encounters (Part 4: Northern Wild Areas)#1581jemarq04 wants to merge 31 commits into
jemarq04 wants to merge 31 commits into
Conversation
…e-10-near-station
…/add-swsh-wild-areas-north
…pdate location areas for area-2 and area-3 in stony-wilderness
…eusability in SWSH
…area prose for the galar region
…/add-swsh-wild-areas-north
… spawns for reusability in SWSH" This reverts commit 11d2e6b.
…/add-swsh-wild-areas-north
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
The continuation of PR #1550, #1564, #1577, addressing issue #1459. I've reviewed each of the location areas as I usually do for encounter PRs that I review formally to try and catch as many mistakes as possible. This will mark an end to the base-game encounters for Sword/Shield, and all that will remain are its DLCs.
This PR adds encounters for all needed conditions (weather and before/after beating the game) in the northern wild areas in Galar. Missing prose was added for each location area that gained encounters as well as all remaining location areas within Galar. This helped me find some extra location areas for locations that only have one, so those were removed and areas were renamed accordingly. The only new location area is
giants-mirror-area-2, andgiants-mirror-areawas renamed togiants-mirror-mainto be consistent.Also, after checking Bulbapedia, I added a missing post-game condition to special wandering Pokemon in the wild areas at level 65 (which had been missing beforehand). Some missing level and percentage differences in southern wild areas were also caught and fixed.
For this, I also realized I had been using the
overworld-specialandoverworld-water-specialencounter methods for the wanderers in the game, as they weren't only-one (static) encounters but were special guaranteed encounters once per day. For consistency, I've edited the prose for these methods to be applicable for both LGPE and SWSH games. However, if we think it would be more descriptive, I can easily change the relevant SWSH encounters to newwandererandwanderer-watermethods with more descriptive prose. What do you think @Naramsim?Edit: Actually, it seems that Bulbapedia considers these wanderer Pokemon as a new method for SWSH and SV: https://bulbapedia.bulbagarden.net/wiki/Wanderer. With that in mind, I made new methods for them and updated the encounter slots accordingly. Sorry I tend to go back-and-forth!
Next will be working on the DLC version split in the API.
AI coding assistance disclosure
No AI used.
Contributor check list