Skip to content

Record the upstream queries where the findings live #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vahid-ahmadi merged 1 commit into from
Aug 12, 2026
Merged

Record the upstream queries where the findings live #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions VALIDATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,21 @@
by this adapter yet. Nothing built on this repository may present model
output as meaningful until this file records passing replications.

## Upstream queries

Findings raised with the DEFINE authors on their own tracker, so the record
here and the record there stay in step:

- [DEFINE_UK_1.1#1](https://github.com/DEFINE-model/DEFINE_UK_1.1/issues/1) —
which code vintage produced Model Manual v1.1 Table 4; the emissions path at
`846081a` runs below the published values.
- [DEFINE_UK_1.1#2](https://github.com/DEFINE-model/DEFINE_UK_1.1/issues/2) —
§3.3.2 uses six parameters absent from Table 5 (α₀GCFPS, α₀bNFF, α₁bNFF,
α₁CRPS, α₂CRPS, α₃CRPS) and two variables defined nowhere in the manual
(r_KNFF, r_KFF), so the section cannot be simulated forward as published;
plus Eq. (84) disagreeing with Table 6 by 3.04x and Eq. (61) contradicting
the stated fuel-price normalisation.

## Standard

Same bar as the suite's other replications (boe-var-model, us-hank-model):
Expand Down
Loading