Update macOS TAXSIM-35 binary for TY 2025 support - #928
Merged
Conversation
The previous bundled binary returned `STOP 1` for tax year 2025, breaking the `compare` subcommand and any 2025 validation flows. The refreshed build (1961912 bytes, downloaded from http://taxsim.nber.org/out2psl/osx) supports TY 2025 and continues to handle TY 2024 / pre-2021 unchanged. Verified: - 2024 + 2025 single records: clean output - 7-record batch (2023-2025, mixed states/filing): 100% federal, 86% state match via the compare subcommand - StitchedRunner pre-2021 path (2018-2020): unchanged behavior Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PavelMakarchuk
added a commit
that referenced
this pull request
Jul 15, 2026
…#1095) * Update stale Linux/Windows taxsimtest binaries to current NBER builds The bundled Linux/Windows binaries dated from Aug 2025 and predated TAXSIM's opt(30) liability-year rebate handling, so test_opt30_aligns_rebate_timing failed on those platforms (VA 2021: siitax 2568.05/srebate 0 instead of 2068.05/500). The macOS binary was already current (#928). Verified via Docker: the new Linux build (2025Dec24) matches PE under opt(30). Fixes the CI failure discussed in #1089. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Surface TAXSIM binary build date and document binary updates Every run now reports the build date the binary stamps into its output header, the opt30 test failure message points at stale-binary diagnosis instead of implying an upstream change, and a README documents how to check and update the bundled binaries. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resources/taxsimtest/taxsimtest-osx.exewith a fresh build from http://taxsim.nber.org/out2psl/osx that supports TY 2025STOP 1on any 2025 record, breaking thecomparesubcommand and 2025 validation flowsVerified locally
compare: 100% federal match, 86% state match (one ~$28 CO 2024 gap, not binary-related)Test plan