Document UC deductions review findings: floor scope, validated years, bias direction - #1821
Merged
Conversation
From the post-merge methodology review on #1815: the protected floor binds on all deduction categories including last resort and child maintenance (JRF's briefing does not state their intent for those); the rate distribution is national and validated for 2024-2025, with earlier years an uncalibrated extrapolation under higher caps; cap-lowering reforms overstate newly constrained households while cap raises rest on the observed 25%-cap distribution; annual amounts are upper bounds for spell-limited types. Adds a graceful-degradation test for zeroed combination shares and promotes the aggregate-caseload caveat to the changelog with pointers to policyengine-uk-data#452 and #450. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Main already carried a fuller floor-binding note and a stronger zero-shares test; drop the redundant additions. State validation correctly: model years 2024-2025 are validated against the March 2025 to February 2026 observations (which begin March 2025). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Main gained fuller validated-years and bias-direction notes in parallel; this branch now adds only the national-composition sentence, the annualization upper-bound note, and the promoted changelog caveat. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1815 addressing the methodology review's documentation and test items:
protected_floor.yamlthat the modeled floor binds on all deduction categories, including last resort and child maintenance (current law allows those above the cap; JRF's briefing does not state whether their design exempts them — flagged for follow-up if it does).🤖 Generated with Claude Code