feat: requester-side combo RFQ support (request quote, accept, wait for fill) - #216
Draft
kartojal wants to merge 2 commits into
Draft
feat: requester-side combo RFQ support (request quote, accept, wait for fill)#216kartojal wants to merge 2 commits into
kartojal wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements DEV-425, porting the requester-side combo RFQ surface from the TypeScript SDK (Polymarket/ts-sdk#251) to idiomatic Python. Adds
request_combo_quote,accept_combo_quote,wait_for_combo_fill, andfetch_rfq_statustoSecureClientandAsyncSecureClient, backed by a new builder-gateway transport that attachesPOLY_*L2 headers plusPOLY_BUILDER_*headers on mutating requests (status reads are account-auth only).Adaptations per the ticket: the BUY/SELL direction-sizing coupling is enforced at runtime via keyword arguments (
amount=for BUY collateral,size=for SELL shares);RfqRejectionCodeis aStrEnumwith unknown-code passthrough;accept_combo_quotetakes theComboQuoteResultfrom the quote request since the status endpoint never returns the bundle. Business outcomes (no quotes, maker declined, expired acceptance window) are returned as result values, not raised.Linear: DEV-425