Care package: game_change, rumble, allow extensions if needed, tidy stubs#22
Care package: game_change, rumble, allow extensions if needed, tidy stubs#22JeodC wants to merge 9 commits intoPortsMaster:masterfrom JeodC:rumble
Conversation
This is necessary for at least one GMS port (Victory Heat Rally)
Immediately return that the video ended Tidy up
JeodC
changed the title
cdeletre
left a comment
cdeletre
left a comment
There was a problem hiding this comment.
I've only minor remarks, with my CPP knowledge I don't see anything wrong.
|
|
||
| uint16_t left_motor = (uint16_t)(left * MAX_RUMBLE_F); | ||
| uint16_t right_motor = (uint16_t)(right * MAX_RUMBLE_F); | ||
| int duration_ms = (left_motor || right_motor) ? 10000 : 0; |
There was a problem hiding this comment.
10000 ms is 10 s
It seems a bit mucho ?
There was a problem hiding this comment.
GameMaker doesn't pass a duration in its arguments, instead handing control to the developer to explicitly turn rumble off. Therefore we need to pass a duration to SDL in its place, but since we don't know how long a developer may want rumble to last, I went with a larger threshold opting for safety. I think if a dev has rumble lasting longer than a few seconds they're insane, but you never know.
There was a problem hiding this comment.
Ok, thanks for the explanation. That's what I suspected :)
Co-authored-by: Cyril Delétré <cyril.deletre@gmail.com>
|
I am rebasing, squashing and reviewing the patches, will give a heads up soon. |
|
Cherry picked into upstream |
3 participants
This pull request is a care package that does the following:
game_changereimplementation (Deltarune launcher works)video_openand for now tells game that video ended immediately (verified with VHR which has a .mp4 logo file)