Skip to content

OpenSSF silver badge: reproducible build#1240

Merged
TonyXiang8787 merged 32 commits into
mainfrom
feature/reproducible-build
Jan 13, 2026
Merged

OpenSSF silver badge: reproducible build#1240
TonyXiang8787 merged 32 commits into
mainfrom
feature/reproducible-build

Conversation

@mgovers
Copy link
Copy Markdown
Member

@mgovers mgovers commented Dec 18, 2025 •
edited
Loading

Cherry-picked from #1228

This investigates the possibilities of producing a reproducible build

Before merge (do-not-merge label)

Relates to #1190

mgovers added 12 commits December 18, 2025 16:25
@mgovers
cmake reproducible builds
113d993 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
reproducible builds + workflow
0f432fb 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
add reproducible build to github actions
c916bf0 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
rename steps
23b76e9 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
gcc reproducibility
4914dc9 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix preset
f851552 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix typo
8f39a2e 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix typo
db86996 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix correct gcc version
b0b4094 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix msvc conda prefix
374754d 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
clean up build dir
8ca8a35 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
remove unused
623452f 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers self-assigned this Dec 18, 2025
@mgovers mgovers added do-not-merge This should not be merged improvement Improvement on internal implementation labels Dec 18, 2025
mgovers
mgovers commented Dec 18, 2025
View reviewed changes
Comment thread .github/workflows/ci.yml Outdated
mgovers and others added 8 commits December 18, 2025 16:46
@mgovers
fix typo
6642d0a 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
msvc reproducible
6b382cf 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
attempt force msvc deterministic
24443ed 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
also force clang-cl deterministic
2bcee2c 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
remove unknown flags clang-cl
2ff99f4 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
random seed and datetime apparently not added to compiler arguments
f32f85f 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge branch 'main' into feature/reproducible-build
6793efd
@mgovers
disable other workflows except for reproducibility
2ce7832 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
mgovers commented Jan 12, 2026
View reviewed changes
Comment thread .github/workflows/ci.yml
@mgovers
reproducible build windows
12a7fc4 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Copy link
Copy Markdown
Member Author

mgovers commented Jan 12, 2026

Reproducible build on windows successful with both msvc and clang-cl in https://github.com/PowerGridModel/power-grid-model/actions/runs/20923965759/job/60116675758?pr=1240 (12a7fc4)

@mgovers
fix script for linux
09d6416 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
test script for macos
1da6be5 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix typo
ae9e722 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
restore CI; reproducible build in nightly
6604d4f 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers marked this pull request as ready for review January 13, 2026 10:35
@mgovers mgovers removed the do-not-merge This should not be merged label Jan 13, 2026
@mgovers
Copy link
Copy Markdown
Member Author

mgovers commented Jan 13, 2026

do-not-merge label removed because the reproducible build check passes in the nightly run https://github.com/PowerGridModel/power-grid-model/actions/runs/20953474927

TonyXiang8787
TonyXiang8787 reviewed Jan 13, 2026
View reviewed changes
Comment thread tests/package_tests/CMakeLists.txt Outdated
TonyXiang8787
TonyXiang8787 reviewed Jan 13, 2026
View reviewed changes
Comment thread .github/workflows/check-build-reproducibility.yml Outdated
TonyXiang8787
TonyXiang8787 reviewed Jan 13, 2026
View reviewed changes
Comment thread .github/workflows/check-build-reproducibility.yml
TonyXiang8787
TonyXiang8787 reviewed Jan 13, 2026
View reviewed changes
Comment thread .github/workflows/check-build-reproducibility.yml
@mgovers
resolve some (not all) comments
c7156f8 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
TonyXiang8787
TonyXiang8787 reviewed Jan 13, 2026
View reviewed changes
Comment thread .github/workflows/check-build-reproducibility.yml Outdated
@mgovers
remove redundant if: runner.os == 'windows'
07770e1 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Copy link
Copy Markdown
Member Author

mgovers commented Jan 13, 2026 •
edited
Loading

Restarted Nightly in https://github.com/PowerGridModel/power-grid-model/actions/runs/20956375532

TonyXiang8787
TonyXiang8787 previously approved these changes Jan 13, 2026
View reviewed changes
@mgovers
Copy link
Copy Markdown
Member Author

mgovers commented Jan 13, 2026

Restarted Nightly in https://github.com/PowerGridModel/power-grid-model/actions/runs/20956375532

this nightly failed on the macos one. Investigating now.

@mgovers
apple clang preset
aafc5ae 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Copy link
Copy Markdown
Member Author

mgovers commented Jan 13, 2026 •
edited
Loading

Restarted Nightly in https://github.com/PowerGridModel/power-grid-model/actions/runs/20956375532

this nightly failed on the macos one. Investigating now.

fix running in https://github.com/PowerGridModel/power-grid-model/actions/runs/20962280036

@mgovers
add forgotten build preset
7c55026 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
cmake shared linker flags
df67e5e 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
reverse + reproducibility
a75da94 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
typo
59a654d 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Copy link
Copy Markdown
Member Author

mgovers commented Jan 13, 2026

another one running in https://github.com/PowerGridModel/power-grid-model/actions/runs/20963875918

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 13, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit e7b073d Jan 13, 2026
59 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/reproducible-build branch January 13, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TonyXiang8787 TonyXiang8787 TonyXiang8787 approved these changes

Assignees

@mgovers mgovers

Labels

improvement Improvement on internal implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgovers @TonyXiang8787