Skip to content

Speedup cold runs of PSSA by using a runspace pool and parallelizing the slowest rule (AvoidAlias) #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesWTruher merged 8 commits into from
Jun 5, 2019
Merged

Speedup cold runs of PSSA by using a runspace pool and parallelizing the slowest rule (AvoidAlias) #1178

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b00ac0b
Speed up cold runs of PSSA by 20% by using a RunspacePool when queryi…
bergmeister Mar 16, 2019
587ac7b
Use runspace pool for rule helper for manifests as well
bergmeister Mar 16, 2019
f8e6114
Speed up cold starts of PSSA by another 35% by parallelising the expe…
bergmeister Mar 16, 2019
785cb3f
Apply suggestions from code review
rjmholt Apr 15, 2019
250e941
Reduce indentation level
bergmeister Apr 15, 2019
1528e99
use build pattern for less repeated code
bergmeister Apr 15, 2019
757e307
trigger ci
bergmeister Apr 16, 2019
29d99cb
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister Jun 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use build pattern for less repeated code
  • Loading branch information
@bergmeister
bergmeister committed Apr 15, 2019
commit 1528e99a92368d20d8bb736f934dfd788bff2d56
6 changes: 3 additions & 3 deletions Engine/Helper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,9 @@ public PSModuleInfo GetModuleManifest(string filePath, out IEnumerable<ErrorReco
using (var ps = System.Management.Automation.PowerShell.Create())
{
ps.RunspacePool = _runSpacePool;
ps.AddCommand("Test-ModuleManifest");
ps.AddParameter("Path", filePath);
ps.AddParameter("WarningAction", ActionPreference.SilentlyContinue);
ps.AddCommand("Test-ModuleManifest")
.AddParameter("Path", filePath)
.AddParameter("WarningAction", ActionPreference.SilentlyContinue);
try
{
psObj = ps.Invoke();
Expand Down