Use AST to determine SupportsShouldProcess when an error is thrown#1397
Merged
bergmeister merged 7 commits intoPowerShell:masterfrom Feb 8, 2020
Merged
Conversation
bergmeister
reviewed
Jan 16, 2020
Collaborator
|
Code change looks ok but the build says it has a problem when targeting psv3, looks like we need a pragma using the |
Co-Authored-By: Christoph Bergmeister [MVP] <c.bergmeister@gmail.com>
Contributor
Author
|
Ok I've repurposed the SafeGetValue substitute method I wrote to handle that. It's now available as a Helper method. |
bergmeister
approved these changes
Feb 8, 2020
Collaborator
bergmeister
left a comment
There was a problem hiding this comment.
Looks good to me. I verified that the diff in Helper.cs/Settings.cs is mainly just the move to make the method publicly accessible.
Only an optional style suggestion.
Co-Authored-By: Christoph Bergmeister [MVP] <c.bergmeister@gmail.com>
Co-Authored-By: Christoph Bergmeister [MVP] <c.bergmeister@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1217.
When PowerShell throws an error due to not being able to resolve an attribute type, we sift through the AST to determine whether
SupportsShouldProcesshas been set on a function.Also cleans up some of the logic so it's not all nested
ass.PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.